Closed
Bug 919704
Opened 11 years ago
Closed 11 years ago
Remove empty screen for "Top sites"
Categories
(Firefox for Android Graveyard :: General, defect, P4)
Tracking
(firefox26 fixed, firefox27 verified)
VERIFIED
FIXED
Firefox 27
People
(Reporter: liuche, Assigned: liuche)
References
Details
Attachments
(2 files, 1 obsolete file)
11.30 KB,
patch
|
sriram
:
review+
|
Details | Diff | Splinter Review |
9.31 KB,
patch
|
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
"Top sites" now includes thumbnails of the most visited sites, so the empty screen for that page will never be displayed. We should remove the resources and references to those resources.
Assignee | ||
Updated•11 years ago
|
Whiteboard: [mentor=liuche][lang=java]
this sounds like it would be a good first bug for me. java is my strongest language so it would be a good intro to development for fennec. would you be happy to mentor me on this as my first bug fix when i get my build environment set up?
Assignee | ||
Comment 2•11 years ago
|
||
Hi basscase, I actually completely forgot I had filed this bug and ended up writing a patch for it in another bug - if you'd like to look at the patch, I'll be uploading it here.
I apologize for the confusion on my part - there another bug that you think you'd like to try out?
And feel free to drop into #mobile on Mozilla's irc server: irc.mozilla.org - we're happy to answer any questions you have there!
Whiteboard: [mentor=liuche][lang=java]
Assignee | ||
Comment 3•11 years ago
|
||
Moved the patch from bug 919230, because I forgot I filed this bug.
Comment 4•11 years ago
|
||
Comment on attachment 809973 [details] [diff] [review]
1-remove-empty-topsites
Review of attachment 809973 [details] [diff] [review]:
-----------------------------------------------------------------
Nice :D
Attachment #809973 -
Flags: review?(sriram) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Target Milestone: --- → Firefox 27
Version: Firefox 26 → Firefox 27
Assignee | ||
Comment 6•11 years ago
|
||
Assignee | ||
Comment 7•11 years ago
|
||
(oops, clipboard fail)
https://hg.mozilla.org/integration/fx-team/rev/e6af0f7d99da
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•11 years ago
|
||
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 917394
User impact if declined: bug 920317 depends on this patch
Testing completed (on m-c, etc.): on m-c for a few weeks
Risk to taking this patch (and alternatives if risky): low, code removal of xml and resources
String or IDL/UUID changes made by this patch: none (leaving in strings that are removed in 27)
Attachment #819190 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 10•11 years ago
|
||
(Updated the patch message to match this bug)
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 917394
User impact if declined: bug 920317 depends on this patch
Testing completed (on m-c, etc.): on m-c for a few weeks
Risk to taking this patch (and alternatives if risky): low, code removal of xml and resources
String or IDL/UUID changes made by this patch: none (leaving in strings that are removed in 27)
Attachment #819190 -
Attachment is obsolete: true
Attachment #819190 -
Flags: approval-mozilla-aurora?
Attachment #819280 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
status-firefox27:
--- → verified
Flags: needinfo?(aaron.train)
Keywords: verifyme
Updated•11 years ago
|
Attachment #819280 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•11 years ago
|
||
status-firefox26:
--- → fixed
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•