Closed
Bug 920376
Opened 11 years ago
Closed 7 years ago
[l10n] Hard coded strings in new features (profile)
Categories
(Participation Infrastructure :: Phonebook, defect)
Participation Infrastructure
Phonebook
Tracking
(Not tracked)
RESOLVED
FIXED
2013-09-26
People
(Reporter: flod, Unassigned, Mentored)
References
Details
(Whiteboard: [Triage 2015-04-17][kb=1126772][qa-] )
When you edit your profile the following strings are hard-coded somewhere and not available in the gettext file. Timezone Add account Fitted, Straight-cut (titles) Sizes. Wouldn't be easier to use letters (i.e. M, XL, L, etc.?) Privileged (list visible to:)
|
Reporter | |
Comment 1•11 years ago
|
||
Timezone, sizes, privileged (?): I guess this is the piece of code involved https://github.com/mozilla/mozillians/blob/master/mozillians/users/models.py#L145 Add account https://github.com/mozilla/mozillians/blob/master/mozillians/phonebook/templates/phonebook/edit_profile.html#L150 Fitted https://github.com/mozilla/mozillians/blob/master/mozillians/phonebook/templates/phonebook/edit_profile.html#L183 Stright-cut https://github.com/mozilla/mozillians/blob/master/mozillians/phonebook/templates/phonebook/edit_profile.html#L203
|
||
Updated•11 years ago
|
Whiteboard: [good first bug][lang=python][mentor=giorgos@mozilla.com]
|
|
||
Updated•11 years ago
|
Whiteboard: [good first bug][lang=python][mentor=giorgos@mozilla.com] → [kb=1126772] [good first bug][lang=python][mentor=giorgos@mozilla.com]
|
|
||
Comment 2•11 years ago
|
||
https://github.com/mozilla/mozillians/pull/642 This doesn't fix the timezone issue. I'll have to investigate further that.
Assignee: nobody → giorgos
Status: NEW → ASSIGNED
Whiteboard: [kb=1126772] [good first bug][lang=python][mentor=giorgos@mozilla.com] → [kb=1126772]
|
||
Comment 3•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/mozillians https://github.com/mozilla/mozillians/commit/d80371c34ca3a3efc450faeee45ddf4a3ef08c4f [bug 920376] Translate hard coded strings in edit profile template. https://github.com/mozilla/mozillians/commit/1c4b8822408486cded9992180237f321429517de Merge pull request #642 from glogiotatidis/920376 [bug 920376] Translate hard coded strings in edit profile template.
|
||
Updated•11 years ago
|
Whiteboard: [kb=1126772] → [kb=1126772][qa-]
|
||
Updated•11 years ago
|
Target Milestone: --- → 2013-09-26
|
|
||
Updated•10 years ago
|
Assignee: giorgos → nobody
Status: ASSIGNED → NEW
|
||
Updated•9 years ago
|
Blocks: 791954
Mentor: jgiannelos
Whiteboard: [kb=1126772][qa-] → [Triage 2015-04-17][kb=1126772][qa-]
|
||
Comment 4•7 years ago
|
||
I am trying to understand if there are other string missings. For now I found few strings but for the timezone is a field so i need to look better in the code itself. PR: https://github.com/mozilla/mozillians/pull/1595
|
|
||
Comment 5•7 years ago
|
||
Commits pushed to master at https://github.com/mozilla/mozillians https://github.com/mozilla/mozillians/commit/a3e658457d69cf8f3d64acf0751e1f58c85cd4bd [bug 920376] Enable localization for the API template https://github.com/mozilla/mozillians/commit/e8ffe642324d16d9fb177d4c9b78710435e9b19b Merge pull request #1595 from Mte90/Mte90/920376 [bug 920376] Enable localization for the API template
|
|
||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•