Closed Bug 920478 Opened 6 years ago Closed 6 years ago

[app manager] if the launch path of an app is missing or invalid, we don't show any warning

Categories

(DevTools :: WebIDE, defect, P1)

x86
All
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: paul, Assigned: ochameau)

References

Details

Attachments

(1 file, 5 obsolete files)

No description provided.
Assignee: nobody → poirot.alex
This adds a bunch of tests against the launch path in the validator
and comes with unit tests.

https://tbpl.mozilla.org/?tree=Try&rev=20580121d10b
Depends on: 926332
Comment on attachment 816491 [details] [diff] [review]
Print errors when something is wrong with app launch path r=paul

Review of attachment 816491 [details] [diff] [review]:
-----------------------------------------------------------------

https://tbpl.mozilla.org/?tree=Try&rev=1c0688ee4510

::: browser/devtools/app-manager/app-validator.js
@@ +54,5 @@
>      this.error(strings.formatStringFromName("validator.invalidManifestURL", [manifestURL], 1));
>      deferred.resolve(null);
>      return deferred.promise;
>    }
> +  req.channel.loadFlags |= Ci.nsIRequest.LOAD_BYPASS_CACHE | Ci.nsIRequest.INHIBIT_CACHING;

This additional flag was required for tests to behave sanely. So it may fix bug 925219.
Attachment #816491 - Flags: review?(paul)
Comment on attachment 816491 [details] [diff] [review]
Print errors when something is wrong with app launch path r=paul

> +  req.channel.loadFlags |= Ci.nsIRequest.LOAD_BYPASS_CACHE | Ci.nsIRequest.INHIBIT_CACHING;


This is important for bug 925219 and we need it in aurora.
But we can't land the whole patch in Aurora (strings).

Can you fix that in bug 925219, or have 2 different patches in this bug?
Attachment #816491 - Flags: review?(paul) → review+
Attached patch Factored out the cache fix (obsolete) — Splinter Review
Attachment #816491 - Attachment is obsolete: true
Attachment #816502 - Flags: review+
Depends on: 925219
I had to modify bug 926332 per review comments.
The getTestFile method is now getTestFilePath and returns a file path instead of nsIFile.
I also fixed a test failure on windows.

I'm carrying over the review as it is really simple updates, but feel free to take another look at it.
Attachment #816502 - Attachment is obsolete: true
Attachment #817128 - Flags: review+
Attachment #817128 - Flags: review+
Attachment #817869 - Flags: review+
Test are green and dependency (bug 926332) is ready to land.
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/7063d9f5c1fd
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Sorry, I had to back out this change because it depends on bug 926332 which was backed out:
https://hg.mozilla.org/integration/fx-team/rev/c31df2ff673f
https://hg.mozilla.org/mozilla-central/rev/894025edbb7b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.