925219 - [app manager] alert for invalid/unsupported manifest type persists after update

Status: VERIFIED FIXED

(DevTools Graveyard :: WebIDE, defect, P1)

Description

[Matthew Schranz [:mjschranz]]

I'm pretty new to FireFox OS dev and I'm spending a lot of my time doing so with App Manager.

I was originally trying to solve a problem by specifying my app type as "certified", which would present an error alert dialog when trying to update. See https://dl.dropboxusercontent.com/spa/qxpeeqhhsjhcqcf/5_5ewubx.png

However, after changing it back to say privileged it would still present that alert even though visually the UI is indicating things are just fine. See https://dl.dropboxusercontent.com/spa/qxpeeqhhsjhcqcf/yhjz2mw4.png

Comment 1

[Alexandre Poirot [:ochameau]]

I've seen some caching issues while adding some additional tests, and fix one such issue.
So it may be fixed by bug 920478.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Fix app validator caching issue

Carrying over the review from bug 920478.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/5d220eac0342

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5d220eac0342

Comment 5

[Paul Rouget [:paul]]

Comment on attachment 816504 [details] [diff] [review]
Fix app validator caching issue

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (app manager)
User impact if declined: can't update its code after 1st push
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/28acf9adf069

Comment 7

[Ioana (away)]

Can you please provide an app we can reproduce/verify this bug with? Some guidelines for updating its code would also be very useful.

Comment 8

[Matthew Schranz [:mjschranz]]

The app (and not touched in a month :() is one I was working on in my spare time as an experiment and can be found at https://github.com/mjschranz/webmaker-ffos

Comment 9

[Ioana (away)]

Thanks for the app Matthew!

Unfortunately, this bug is still reproducible for me on:
Mozilla/5.0 (X11; Linux i686; rv:26.0) Gecko/20100101 Firefox/26.0 - 20131114085019

After changing the app to "privileged" and refreshing the App Manager, it shows that the app is valid but it gives me "installationFailed: Installing certified apps is not allowed." when trying to debug it.

I tested with the 1.2 simulator given that 1.3 lets me debug certified apps.

Comment 10

[Petruta Horea [:phorea], Desktop Test Engineering]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:27.0) Gecko/20100101 Firefox/27.0
Mozilla/5.0 (X11; Linux i686; rv:27.0) Gecko/20100101 Firefox/27.0

The initial issue doesn't reproduce anymore on Nightly 27 (2013-10-09). It is the same behavior for Firefox 27 beta 5 (20140109165205).
The certified apps can be debugged from the beginning and also after changing the manifest type from "certified" to "privileged".

Paul, I suppose this is because now the certified apps can be debugged (bug 927108). Is this correct? Thank you!

Comment 11

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Yes, looks like this is now resolved in 27 by including the fix from bug 927108.

Comment 12

[Petruta Horea [:phorea], Desktop Test Engineering]

Thanks Ryan, marking as verified.