920603 - Add a qHD skin to the emulator

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Emulator, defect)

Description

[Gabriele Svelto [:gsvelto]]

The wasabi device uses a qHD resolution which is currently not supported out-of-the-box by our emulator. Adding a skin for it would greatly simplify testing UI patches for those who do not have the device at hand or need to use the emulator for any other reason.

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: [PATCH] Add a qHD skin for the emulator

This patch adds a qHD skin based on the WVGA800 with all dimensions and DPI ratio adjusted for the qHD resolution (540x960) and new portrait/landscape backgrounds that properly fit the device screen.

Comment 2

[Gabriele Svelto [:gsvelto]]

Attachment: [PULL REQUEST] Add a qHD skin for the emulator

Pointer to Github pull-request

Comment 3

[Michael Wu [:mwu]]

Hm, this only adds support for the ICS emulator. Any idea if the JB emulator comes with a qHD skin? We don't need it there at the moment, but it would be nice to have.

Comment 4

[Gabriele Svelto [:gsvelto]]

(In reply to Michael Wu [:mwu] from comment #3)
> Hm, this only adds support for the ICS emulator. Any idea if the JB emulator
> comes with a qHD skin? We don't need it there at the moment, but it would be
> nice to have.

I had checked the master branch in Google's repository and it doesn't have qHD skin yet so I assume the JB emulator doesn't either:

https://github.com/android/platform_development/tree/master/tools/emulator/skins

I can prepare a pull-request for the JB emulator using this patch as it shouldn't require any modification.

Comment 5

[Gabriele Svelto [:gsvelto]]

I've checked the exact version used by the JB emulator and it doesn't have a qHD skin either:

https://android.googlesource.com/platform/development/+/android-4.3_r2.1/tools/emulator/skins/

Looking at our manifest it seems to me that we're pulling it directly from the Android repos. Is that the plan? In that case do you want me to try and push this upstream too?

Comment 6

[Michael Wu [:mwu]]

Upstream would be great if they take it. Lemme know if you try that - I would probably need to add you to the corporate contributor list.

Comment 7

[Michael Wu [:mwu]]

Comment on attachment 809976 [details] [diff] [review]
[PATCH] Add a qHD skin for the emulator

I'm just gonna assume this was tested. :)

(also, if you have a PR, asking for review on that is usually enough)

Comment 8

[Gabriele Svelto [:gsvelto]]

(In reply to Michael Wu [:mwu] from comment #7)
> Comment on attachment 809976 [details] [diff] [review]
> [PATCH] Add a qHD skin for the emulator
> 
> I'm just gonna assume this was tested. :)

Yep, I've been using it to reproduce a UI layout problem that happens only on the wasabi which I don't have :)

> (also, if you have a PR, asking for review on that is usually enough)

I know but I've been attaching patches besides PRs lately in Gaia (and other components) so that when people look up the bug they can find the patch that landed and the review comments on the bug instead of having to go and look them up on GitHub.

Comment 9

[Gabriele Svelto [:gsvelto]]

Merged to emu-fix 4e236e65a5d652a66ac32590f69f2123d17cb4ad