920623 - Remove the css animation 'peek' hack in settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

This hurts panel animations...

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: settings.no.peek.patch

Let's ask Etienne since IIRC he did the original hack back in those blocking-basecamp days.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: settings.no.peek.patch

Sigh the same patch but with everything inside.

Comment 3

[Etienne Segonzac (:etienne)]

Comment on attachment 810005 [details] [diff] [review]
settings.no.peek.patch

Review of attachment 810005 [details] [diff] [review]:
-----------------------------------------------------------------

Yay for removing b2g18 hacks!

We're not using the .forward class anymore either :)
Let's clean this too in the same patch since it's related.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: settings.no.peek.v2.patch

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 810499 [details] [diff] [review]
settings.no.peek.v2.patch

Review of attachment 810499 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
But you also need the stamp of approval of a Settings peer.

The code is cleaner, no white screens to be seen and we skip less transitions (not perfect yet ;)).
I'm sure Kaze will like it since I remember him asking to add the comment in the first place to make sure we removed this hack once we left b2g18.

Comment 6

[Fabien Cazenave [:kaze]]

(In reply to Etienne Segonzac (:etienne) from comment #5)
> I'm sure Kaze will like it since I remember him asking to add the comment in
> the first place to make sure we removed this hack once we left b2g18.

I confirm. Nice to see this happen! :-)

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/0190f97558e40b9d7ddca71318e2cdb8b2a52496