Closed
Bug 920642
Opened 12 years ago
Closed 12 years ago
rm dead files
Categories
(Android Background Services Graveyard :: Firefox Health Report Service, defect)
Android Background Services Graveyard
Firefox Health Report Service
All
Android
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(1 file)
|
12.86 KB,
patch
|
nalexander
:
review+
|
Details | Diff | Splinter Review |
Bug 870171 rm'd some files in the git repo but these files were not removed in m-c due to bug 920641 and user error. :)
Ex: <m-c>/mobile/android/base/uploadHealthReportUploadBroadcastReceiver.java
`hg rm` them.
|
Assignee | |
Updated•12 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•12 years ago
|
||
> <m-c>/mobile/android/base/uploadHealthReportUploadBroadcastReceiver.java
I mean <m-c>/mobile/android/base/background/healthreport/upload/HealthReportBroadcastReceiver.java.
See: http://hg.mozilla.org/mozilla-central/file/681a8e611ede/mobile/android/base/background/healthreport/upload/HealthReportBroadcastReceiver.java
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #810045 -
Flags: review?(rnewman)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 810045 [details] [diff] [review]
01: Patch
rnewman has enough to review, I'll look at this.
Attachment #810045 -
Flags: review?(rnewman) → review?(nalexander)
|
|
||
Comment 4•12 years ago
|
||
Comment on attachment 810045 [details] [diff] [review]
01: Patch
Review of attachment 810045 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm, matches against
commit 235a992092416c21b45903bdee1d1c898003c737
Merge: f72c397 62a5797
Author: Michael Comella <michael.l.comella@gmail.com>
Date: Thu Sep 19 17:35:23 2013 -0400
Make sure mobile/android/base builds from clean (make -C $OBJDIR mobile/android/base clean && make -C mobile/android/base, or similar). This will verify that these files aren't in android-services-files.mk.
Attachment #810045 -
Flags: review?(nalexander) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
> Make sure mobile/android/base builds from clean
Looks good.
https://hg.mozilla.org/integration/fx-team/rev/9902fa0a293d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•