920919 - Set MOZ_PSEUDO_DERECURSE to no-parallel-export by default on developer builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

I think it's time to do it.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Set MOZ_PSEUDO_DERECURSE to no-parallel-export by default on developer builds... when not using pymake

Comment 2

[Mike Hommey [:glandium]]

Attachment: Set MOZ_PSEUDO_DERECURSE to no-parallel-export by default on developer builds... when not using pymake

New variant that also allows to disable it by defining "MOZ_PSEUDO_DERECURSE=" in mozconfig.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 810439 [details] [diff] [review]
Set MOZ_PSEUDO_DERECURSE to no-parallel-export by default on developer builds... when not using pymake

Review of attachment 810439 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/config.mk
@@ +101,5 @@
>  
> +ifdef .PYMAKE
> +comma = ,
> +ifneq (,$(filter no-pymake,$(subst $(comma), ,$(MOZ_PSEUDO_DERECURSE))))
> +MOZ_PSEUDO_DERECURSE :=

Why the comma foo? Can't we just do space-delimited words?

Please add a comment linking to the bug tracking the pymake assertion.

Comment 4

[Mike Hommey [:glandium]]

(In reply to Gregory Szorc [:gps] from comment #3)
> Why the comma foo? Can't we just do space-delimited words?

The recursivemake.py code already looks for a comma. That could be changed, but i also prefer to not have spaces in shell variables.

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/38f3ec7c1be1

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/38f3ec7c1be1

Comment 7

[Mike Hommey [:glandium]]

Fixup for windows developer builds bustage:
https://hg.mozilla.org/mozilla-central/rev/1a2d9a04ffb2