923827 - Non tinderbox builds fail in ldap and db with binaries target not found

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Ian Neal]

If enable release is not set then MOZ_PSEUDO_DERECURSE is set to no-parallel-export,no-pymake,no-skip causing builds to fail in ldap with
make[6]: *** No rule to make target `binaries'.  Stop.

This was caused by the landing of bug 920919 - http://hg.mozilla.org/mozilla-central/rev/38f3ec7c1be1

Workaround is to either set enable release or to do make MOZ_PSEUDO_DERECURSE= in the obj_dir

Comment 1

[Ian Neal]

Also affects db directory in addition to ldap one.

Comment 2

[Justin Wood (:Callek)]

gps told me to needinfo you

Comment 3

[Mike Hommey [:glandium]]

What build target are you invoking? There should be nothing trying to build "binaries" unless you explicitly ask for it.

Comment 4

[Ian Neal]

I'm just doing a simple make -f client.mk in the root of comm-central
Makes no difference if obj_dir has been cleared out or not

Comment 5

[Mike Hommey [:glandium]]

Makes no sense. How is ldap recursed?

Comment 6

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #5)
> Makes no sense. How is ldap recursed?

So, ldap and db are recursed by the m-c build system, not c-c's. Why?

Comment 7

[Justin Wood (:Callek)]

because they get linked into libxul

Comment 8

[Mike Hommey [:glandium]]

(In reply to Justin Wood (:Callek) from comment #7)
> because they get linked into libxul

Since tier inversion, in m-c at least, this is not a good enough reason.

Comment 9

[Landry Breuil (:gaston)]

I also saw this issue on my buildbot running gmake -f client.mk:

http://buildbot.rhaalovely.net/builders/comm-central-freebsd-amd64/builds/113
http://buildbot.rhaalovely.net/builders/comm-central-amd64/builds/877

Comment 10

[Joshua Cranmer [:jcranmer]]

(In reply to Mike Hommey [:glandium] from comment #6)
> (In reply to Mike Hommey [:glandium] from comment #5)
> > Makes no sense. How is ldap recursed?
> 
> So, ldap and db are recursed by the m-c build system, not c-c's. Why?

The entire build system is built from mozilla-central, but it uses comm-central's config/ instead (mainly for path reasons). Having a single top-level moz.build file is necessary to fix a lot of issues (without it, all the code that assumes that iterating moz.build finds everything is broken--this includes XPIDL and test manifests at the moment).

Comment 11

[Mike Hommey [:glandium]]

Attachment: Disable pseudo derecurse when building mozilla/ from comm-central

Comment 12

[Joshua Cranmer [:jcranmer]]

Comment on attachment 814684 [details] [diff] [review]
Disable pseudo derecurse when building mozilla/ from comm-central

Review of attachment 814684 [details] [diff] [review]:
-----------------------------------------------------------------

Not the best solution, but so long as this patch holds until cc-rework is complete, I suppose working local builds trump intellectual purity.

Comment 13

[Joshua Cranmer [:jcranmer]]

Pushed:
https://hg.mozilla.org/comm-central/rev/01c56e89552c

Comment 14

[Landry Breuil (:gaston)]

And my c-c builder came back to green: http://buildbot.rhaalovely.net/builders/comm-central-amd64/builds/879

thanks!