921231 - [B2G][Buri][Homescreen] User is unable to remove more than one app or favorite from the homescreen.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[J Zimbrick]

Attachment: Logcat during first successful deletion and second failed attempt.

Description:
User is unable to remove more than one app from the homescreen. Attempting to delete more just takes the user out of edit mode.

Pre-requisites:
Have some e.me sections, web favorites, or third party apps installed to the homescreen.

Repro Steps:
1. Update Buri to master/m-c build 20130926040202.
2. On the homescreen, longtap an icon. The device should be in edit mode.
3. Attempt to delete an app by pressing the red x icon, a prompt appears and the app should be deleted after accepting.
4. Attempt to delete a second app by pressing its red x icon.
5. Observe that the user is taken out of edit mode and the app is not deleted.

Actual:
The second app the user attempts to remove is not deleted, instead the user is taken out of edit mode.

Expected:
The app is deleted without issue.

Environmental Variables
Build ID: 20130926040202
Gecko: http://hg.mozilla.org/mozilla-central/rev/e85b0372cece
Gaia: fc222c4fb720d97ce3933e3f8891498c9c3f49b3
Platform Version: 27.0a1
Base Image: 20130912

Notes:
Repro frequency: 95% on 4 devices, sometimes a user is able to delete two apps in a row, but none after that.

See attached: logcat

It seems that each time the user resets the phone, they are able to delete another app, but then will hit this bug again.

It's also been observed that the user may sometimes be able to delete an app after waiting about ten minutes after encountering this issue.

Comment 1

[Jason Smith [:jsmith]]

Can you reproduce this on 1.2?

I'm guessing this is likely caused by the everything.me changes. A regression window will confirm that.

Comment 2

[J Zimbrick]

Regression Window:

Last working Build:
Environmental  Variables:
Build ID: 20130925174530
Gecko: http://hg.mozilla.org/mozilla-central/rev/fa0e6916f88c
Gaia: 7e42b4d690049709c62e8783910f16ab20869f42
Platform Version: 27.0a1

First Broken Build:
Environmental  Variables:
Build ID: 20130926040202
Gecko: http://hg.mozilla.org/mozilla-central/rev/e85b0372cece
Gaia: fc222c4fb720d97ce3933e3f8891498c9c3f49b3
Platform Version: 27.0a1

Comment 3

[Mila Davydova]

I was not able to reproduce it on 1.2 Buri build: 

Build ID: 20130926004001
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/caa6b17647c5
Gaia: 1e9470b9b6df630eddf1c4c8b25b3170ee786b0e
Platform Version: 26.0a2

Comment 4

[Jason Smith [:jsmith]]

That confirms this is likely caused by the 1.2 everything.me changes then. We probably haven't uplifted yet.

Comment 5

[Cristian Rodriguez (:crdlc)]

This is the regression bug 920357

Comment 6

[Cristian Rodriguez (:crdlc)]

Hi,

   Back out your commit from master or try to fix it

Thanks a lot

Comment 7

[Cristian Rodriguez (:crdlc)]

As I said it is not caused by 1.2 ev.me

(In reply to Jason Smith [:jsmith] from comment #4)
> That confirms this is likely caused by the 1.2 everything.me changes then.
> We probably haven't uplifted yet.

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Cristian,

Sorry, I should bind the click event on right place instead of body, or we might cancel the edit mode by clicking ConfirmDialog .

Please kindly review this fix, thanks.

Comment 9

[Cristian Rodriguez (:crdlc)]

Comment on attachment 811266 [details]
PR to master

It works perfect in my device with this patch, thanks a lot

Comment 10

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/b1b585c45f5153ebea9369292eaddb3133cb5107

Comment 11

[KTucker [:KTucker][Inactive 3/4/2016]]

If the user long presses on a app and selects cancel or remove, the user is taken out of edit mode. The apps will top pulsating. Is this a different issue that should be written up or will the fix for this issue address that as well?

Comment 12

[KTucker [:KTucker][Inactive 3/4/2016]]

Sorry the above comment contains a typo. It should have said the apps will "stop pulsating" not "top pulsating".

Comment 13

[Cristian Rodriguez (:crdlc)]

Hi, could you take a look again? Thanks

Comment 14

[(Inactive after June) George Duan [:gduan] [:喬智]]

Hi,

I just tested. This patch should fix the pb of comment 11.
Could you test it again with latest gaia (later than 2013-09-30 02:12:58) ?
Thanks.

Comment 15

[KTucker [:KTucker][Inactive 3/4/2016]]

Both of these issues appear to be fixed on the latest Buri v 1.2.0 COM RIL

Environmental Variables
Device: Buri v 1.2.0 COM RIL
Build ID: 20131001041206
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/c630289d6388
Gaia: 02b975e6ce12922928c74276ac7d19432a03f126
Platform Version: 18.1
RIL Version: 01.01.00.019.240 

The user can delete more than one app and the user stays in edit mode after canceling or removing an app.

Comment 16

[KTucker [:KTucker][Inactive 3/4/2016]]

Verified Fixed on Buri v1.3.0 Build

Environmental Variables
Device: Buri v 1.3.0 Master
Build ID: 20131001040206
Gecko: http://hg.mozilla.org/mozilla-central/rev/d71579c316c1
Gaia: 67243760c86561e365bdd6def519105366e24be3
Platform Version: 27.0a1

The user is able to delete multiple apps. Also, edit mode remains in effect after the user cancels or removes an app.