920357 - [Flatfish][Homescreen] Add the ability to dismiss app grid edit mode by tapping in an area of the view where there is no icon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

Add the ability to dismiss app grid edit mode by tapping in an area of the view where there is no icon.

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

This patch add click event listener when in edit mode and go back to normal mode by clicking non-icon area.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 809635 [details]
PR to master

Hi Vivien,

Could you help me review this patch?
UX suggest to click non-icon space to cancel edit mode.

Thanks.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 809635 [details]
PR to master

I'm fine with the code but I want to make sure Christian knows about it.

Comment 4

[Cristian Rodriguez (:crdlc)]

There is a problem, I gonna explain you on github

Comment 5

[Cristian Rodriguez (:crdlc)]

Comment on attachment 809635 [details]
PR to master

Please address my comment on github and check if while you are in edit mode and move to other page starting the gesture over a place without icon, this new behavior is not performed. I guess that it shouldn't be so but please check that.. Thanks a great work!

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks, Vivien and Christian.
I've addressed your advice and tested, it works as expected. 

Merged into master,
https://github.com/mozilla-b2g/gaia/commit/2dffbc3ccf4a50dd78c0bc624a8ac419d30a0cc1

Comment 7

[[e-mail]]

It's UX request feature for 1.2. request koi+ for uplift permission

Comment 8

[Gregor Wagner [:gwagner]]

(In reply to Fred Lin [:gasolin] from comment #7)
> It's UX request feature for 1.2. request koi+ for uplift permission

It's a feature and we are past the FC deadline. So approval-request with risk-analysis is the way to go :)