Closed Bug 921330 Opened 6 years ago Closed 6 years ago

Mac sync unwind not working

Categories

(Core :: Gecko Profiler, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: BenWa, Assigned: aklotz)

References

Details

Attachments

(1 file)

I'm trying the SyncProfile for IO markers and I'm getting only the leaf. FramePointerStackWalk is being called but it's not unwinding anything.

My guess is TickSample::PopulateContext is wrong. It's getting the sp/fp when inside PopulateContext which aren't good values once we return from that function.
Can you please give this try build a shot and let me know if this looks better?
https://tbpl.mozilla.org/?tree=Try&rev=6347fc67bc09
Assignee: nobody → aklotz
Status: NEW → ASSIGNED
Flags: needinfo?(bgirard)
Attached patch Potential fixSplinter Review
I did with no improvements.
Flags: needinfo?(bgirard)
I tried this out on a hackintosh VM and I got this:
http://people.mozilla.org/~bgirard/cleopatra/#report=4941e6a308c1acf9b0ce22888ea6eec4c85d2567

I'm seeing stacks in the I/O markers...
Ahh it works now. I think I tested with the wrong profiler options selected. It seems to inherit the options you have selected for sync unwinding and I didn't have 'stackwalk' checked. Things work now.
Attachment #811339 - Flags: review?(bgirard)
Attachment #811339 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/5907769bfe89
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.