921330 - Mac sync unwind not working

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Benoit Girard (:BenWa)]

I'm trying the SyncProfile for IO markers and I'm getting only the leaf. FramePointerStackWalk is being called but it's not unwinding anything.

My guess is TickSample::PopulateContext is wrong. It's getting the sp/fp when inside PopulateContext which aren't good values once we return from that function.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Can you please give this try build a shot and let me know if this looks better?
https://tbpl.mozilla.org/?tree=Try&rev=6347fc67bc09

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Potential fix

Comment 3

[Benoit Girard (:BenWa)]

I did with no improvements.

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

I tried this out on a hackintosh VM and I got this:
http://people.mozilla.org/~bgirard/cleopatra/#report=4941e6a308c1acf9b0ce22888ea6eec4c85d2567

I'm seeing stacks in the I/O markers...

Comment 5

[Benoit Girard (:BenWa)]

Ahh it works now. I think I tested with the wrong profiler options selected. It seems to inherit the options you have selected for sync unwinding and I didn't have 'stackwalk' checked. Things work now.

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

Try build in comment 1.

https://hg.mozilla.org/integration/mozilla-inbound/rev/5907769bfe89

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5907769bfe89