Closed Bug 929763 Opened 6 years ago Closed 6 years ago

Enabling profiler add-on on local builds causes a crash

Categories

(Core :: Gecko Profiler, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: mconley, Assigned: aklotz)

References

Details

(Keywords: crash)

Attachments

(1 file)

Not sure when this started happening, but for local builds, if I try to enable the Gecko Profiler add-on, I immediately crash.

This is not the case with Nightly builds, which is pretty frustrating.

Here's a stack trace:

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x00000000000150b2
0x0000000102142d24 in TickSample::PopulateContext (this=0x7fff5fbe7d60, aContext=0x0) at /Users/mikeconley/Projects/ux/tools/profiler/platform-macos.cc:419
419	  asm (
(gdb) bt
#0  0x0000000102142d24 in TickSample::PopulateContext (this=0x7fff5fbe7d60, aContext=0x0) at /Users/mikeconley/Projects/ux/tools/profiler/platform-macos.cc:419
#1  0x00000001021380c7 in TableTicker::GetBacktrace (this=0x11c3dc700) at /Users/mikeconley/Projects/ux/tools/profiler/TableTicker.cpp:627
Backing out bug 921330 seems to fix things locally... tentatively marking as blocking.
Blocks: 921330
Attached patch PatchSplinter Review
We should only be calling TickSample::PopulateContext if HAVE_NATIVE_UNWIND is set.
Assignee: nobody → aklotz
Attachment #820702 - Flags: review?(bgirard)
Comment on attachment 820702 [details] [diff] [review]
Patch

Review of attachment 820702 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the fast response!
Attachment #820702 - Flags: review?(bgirard) → review+
https://hg.mozilla.org/mozilla-central/rev/ac4f0cba097a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.