Closed Bug 921404 Opened 12 years ago Closed 12 years ago

[Flatfish][Lockscreen] screen clock is too small on tablet

Categories

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Lockscreen
Platform:
Other
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:-, b2g-v1.2 fixed, b2g-v1.3 fixed)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g -
Tracking Flags:
Tracking Status
b2g-v1.2 --- fixed
b2g-v1.3 --- fixed

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

Attachments

(5 files)

current lockscreen clock
969.19 KB, image/png
Details
clock modified
983.91 KB, image/png
Details
lockscreen clock follow 9/27 spec
974.48 KB, image/png
Details
pull request redirect to github
181 bytes, text/html
timdream
: review+
timdream
: review+
bajaj
: approval-gaia-v1.2+
Details
fix top-padding between date and time
970.36 KB, image/png
Details
Current lockscreen clock looks not good on tablet expect: port clock style from gaia-local https://github.com/gaia-local/gaia/blob/master/apps/system/style/lockscreen/lockscreen.css
Summary: [Flatfish][Lockscreen] screen clock is too small → [Flatfish][Lockscreen] screen clock is too small on tablet
Attached image clock modified —
@helen, is it looks right for lockscreen clock on tablet?
Flags: needinfo?(hhuang)
Assignee: nobody → gasolin
Attachment #813012 - Flags: review?(timdream)
Blocks: flatfish
Comment on attachment 813012 [details] pull request redirect to github Thanks!
Attachment #813012 - Flags: review?(timdream) → review+
@Fred, the distance between time and date is too close, please refer to export image.
show helen offline and she has some suggestions. here's after-tuning screenshot
Comment on attachment 813012 [details] pull request redirect to github merge style changes into lockscreen-header class
Attachment #813012 - Flags: review?(timdream)
nominate for koi since its low risk and could improve look and feel when user first see the lockscreen on tablet
blocking-b2g: --- → koi?
Attachment #813012 - Flags: review?(timdream) → review+
merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/434bfb50ffeedf1ff5b9a1d3bf94c5717687872a thanks!
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(hhuang)
Resolution: --- → FIXED
(In reply to Fred Lin [:gasolin] from comment #9) > nominate for koi since its low risk and could improve look and feel when > user first see the lockscreen on tablet Cannot block on this issue as this does not meet the blocking criteria. Please request approval-gaia-v1.2 on this so this can be uplifted to 1.2.
blocking-b2g: koi? → -
Flags: needinfo?(timdream)
Flags: needinfo?(gasolin)
Comment on attachment 813012 [details] pull request redirect to github NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): [User impact] if declined: lockscreen clock is small on tablet [Testing completed]: [Risk to taking this patch] (and alternatives if risky): low risk, not effect phone [String changes made]:
Attachment #813012 - Flags: approval-gaia-v1.2?
Flags: needinfo?(timdream)
Flags: needinfo?(gasolin)
Attachment #813012 - Flags: approval-gaia-v1.2? → approval-gaia-v1.2+
(In reply to Fred Lin [:gasolin] from comment #9) > nominate for koi since its low risk and could improve look and feel when > user first see the lockscreen on tablet Yeah, this statement is to be used for approval, not blocking. Fred, please uplift this patch manually as uplifters over covers blocking bugs. Thanks!
Flags: needinfo?(gasolin)
uplifted to v1.2 4a9a3be36d0e7bbba3860a92dcaba3b01ab095cd
status-b2g-v1.2: --- → fixed
Flags: needinfo?(gasolin)
fix uplift, not do it clearly... 39d0468564fbbab6cc91daf8d69f3b17a6f75dfb
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: