921404 - [Flatfish][Lockscreen] screen clock is too small on tablet

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[[e-mail]]

Current lockscreen clock looks not good on tablet

expect:

port clock style from gaia-local https://github.com/gaia-local/gaia/blob/master/apps/system/style/lockscreen/lockscreen.css

Comment 1

[[e-mail]]

Attachment: current lockscreen clock

Comment 2

[[e-mail]]

Attachment: clock modified

@helen, is it looks right for lockscreen clock on tablet?

Comment 3

[[e-mail]]

Attachment: lockscreen clock follow 9/27 spec

Comment 4

[[e-mail]]

Attachment: pull request redirect to github

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 813012 [details]
pull request redirect to github

Thanks!

Comment 6

[Helen Huang [:HHuang]]

@Fred, the distance between time and date is too close, please refer to export image.

Comment 7

[[e-mail]]

Attachment: fix top-padding between date and time

show helen offline and she has some suggestions. here's after-tuning screenshot

Comment 8

[[e-mail]]

Comment on attachment 813012 [details]
pull request redirect to github

merge style changes into lockscreen-header class

Comment 9

[[e-mail]]

nominate for koi since its low risk and could improve look and feel when user first see the lockscreen on tablet

Comment 10

[[e-mail]]

merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/434bfb50ffeedf1ff5b9a1d3bf94c5717687872a

thanks!

Comment 11

[bhavana bajaj [:bajaj]]

(In reply to Fred Lin [:gasolin] from comment #9)
> nominate for koi since its low risk and could improve look and feel when
> user first see the lockscreen on tablet

Cannot block on this issue as this does not meet the blocking criteria. Please request approval-gaia-v1.2 on this so this can be uplifted to 1.2.

Comment 12

[[e-mail]]

Comment on attachment 813012 [details]
pull request redirect to github

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 
[User impact] if declined: lockscreen clock is small on tablet
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky): low risk, not effect phone
[String changes made]:

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Fred Lin [:gasolin] from comment #9)
> nominate for koi since its low risk and could improve look and feel when
> user first see the lockscreen on tablet

Yeah, this statement is to be used for approval, not blocking.

Fred, please uplift this patch manually as uplifters over covers blocking bugs. Thanks!

Comment 14

[[e-mail]]

uplifted to v1.2 4a9a3be36d0e7bbba3860a92dcaba3b01ab095cd

Comment 15

[[e-mail]]

fix uplift, not do it clearly... 39d0468564fbbab6cc91daf8d69f3b17a6f75dfb

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

Already on v1.3