921519 - Really disable the slow script dialog on B2G

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Debugging bug 884394, I found that we end up hanging trying to bring up the slow script dialog (we try to bring up the dialog, but as far as I can tell, nobody is listening) and end up hanging in BrowserElementChild._waitForResult.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1

A value of 0 means "don't do that."

Comment 2

[Bobby Holley (:bholley)]

Comment on attachment 811186 [details] [diff] [review]
patch v1

Review of attachment 811186 [details] [diff] [review]:
-----------------------------------------------------------------

r=bholley with comments.

::: b2g/app/b2g.js
@@ +187,5 @@
>  pref("dom.max_chrome_script_run_time", 0); // disable slow script dialog for chrome
>  // Disable the watchdog thread for B2G. See bug 870043 comment 31.
>  pref("dom.use_watchdog", false);
> +pref("dom.max_script_run_time", 0);
> +pref("dom.max_chrome_script_run_time", 0);

This is redundant with the line 2 lines up. Remove the previous one and keep these together.

Also, please add a comment explaining why we need to both disable the watchdog and disable the listener.

Comment 3

[Gregor Wagner [:gwagner]]

Blocks a blocker.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch v1.1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/54a7972a9358

Comment 6

[Gregor Wagner [:gwagner]]

\o/

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/54a7972a9358

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4c72e82e825f