Closed Bug 921690 Opened 12 years ago Closed 12 years ago

Test for mozPay

Categories

(Firefox Graveyard :: Webapp Runtime, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Test (obsolete) — Splinter Review
Let's add a simple test for mozPay to avoid regressions in the webapp runtime.
Attachment #811457 - Flags: review?(ferjmoreno)
Comment on attachment 811457 [details] [diff] [review] Test Review of attachment 811457 [details] [diff] [review]: ----------------------------------------------------------------- Thanks Marco! ::: webapprt/PaymentUIGlue.js @@ +100,5 @@ > > // Inject paymentSuccess and paymentFailed methods into the document after > // its loaded. > + win.addEventListener("DOMContentLoaded", function onWindowCreated() { > + win.removeEventListener("DOMContentLoaded", onWindowCreated); s/onWindowCreated/onDOMContentLoaded @@ +109,5 @@ > > + browserElement.addEventListener("DOMWindowCreated", > + function onBrowserWindowCreated() { > + browserElement.removeEventListener("DOMWindowCreated", > + onBrowserWindowCreated); s/onBrowserWindowCreated/onDOMWindowCreated and align the function properly, please.
Attachment #811457 - Flags: review?(ferjmoreno) → review+
Attached patch PatchSplinter Review
Assignee: nobody → mcastelluccio
Attachment #811457 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #814209 - Flags: review+
Keywords: checkin-needed
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: