921776 - Notifications aren't properly dismissed when multiple downloads are started from private tabs

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Download Manager, defect)

Description

[Richard Newman [:rnewman]]

Bug report from SUMO:

"when a download is started from a private tab the notification is automatically dismissed upon completion. if multiple downloads are active this goes wrong. the notification for the completed download will show the status and filename of the ongoing download, while the notification originally belonging to the ongoing download will keep displaying the % the ongoing download had when the other download finished. "

https://support.mozilla.org/en-US/questions/972655

Comment 1

[Federico Paolinelli]

Attachment: bug-921776-fix

In short: the notifications were switching one over the other. Setting the "when" parameter fixed the behaviour. While fixing this one, I found another bug which prevented the remanining notification to be set as the new foreground one.

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 814559 [details] [diff] [review]
bug-921776-fix

Review of attachment 814559 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/NotificationService.java
@@ +9,5 @@
>  import android.app.Service;
>  import android.content.Intent;
>  import android.os.Binder;
>  import android.os.IBinder;
> +import android.util.Log;

Don't need this

Comment 3

[Federico Paolinelli]

Attachment: bug-921776-fix

That was easy. 
I take the liberty to mark this as review+ since I am confident I did not break anything removing that import :)

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/76251cfbba5b

If this looks ok, we should uplift.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/76251cfbba5b

Comment 6

[Aaron Train [:aaronmt]]

I'm on Nightly (10/15, https://hg.mozilla.org/mozilla-central/rev/febfe3c7732b) and am still seeing the behaviour described in comment #0 – on download completion, the notification is automatically dismissed. The same task performed in regular tabs will persist the notification.

On 10/15 Nightly: new private tab, http://nightly.mozilla.org, tap the Android APK download button

Comment 7

[Federico Paolinelli]

:-( 
Will check as soon as I get home

Comment 8

[Federico Paolinelli]

Ok, I see what's going on. 
I focused on the fact that multiple downloads were overlapping not noticing the notification disappeared part. Patch coming soon for this other issue.
Sorry about this!

Comment 9

[Federico Paolinelli]

Attachment: bug-921776-fix2

This should (eventually ?) fix the download complete notification not showing for private downloads.

Comment 11

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/0792108113b0

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0792108113b0

Comment 13

[Aaron Train [:aaronmt]]

I think 26 is affected here, what's the risk towards uplifting?

Comment 14

[Federico Paolinelli]

There were two different issues (and patches) here. The first one was about having multiple notifications overlapping, and it was strictly related to the new downloads / notificatoins restyling. This should not affect 26.

The other one was private downloads notifications not dismissed when started from private tabs, and this is the one 26 is affected. The patch that solves this is https://bugzilla.mozilla.org/attachment.cgi?id=817378, and I think the risks in uplifting it are pretty low.

Comment 15

[Wesley Johnston (:wesj)]

Comment on attachment 817378 [details] [diff] [review]
bug-921776-fix2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 815202
User impact if declined: Private download notifications hide as soon as the download finishes
Testing completed (on m-c, etc.):  been on mc for a month
Risk to taking this patch (and alternatives if risky): Low risk. Just fixing some js namespcae problems.
String or IDL/UUID changes made by this patch: none

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a39f4c0f075d

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/a39f4c0f075d

Comment 18

[Ioana Chiorean]

Tested with Galaxy Nexus (4.3) using:
Firefox 26 Beta 8 
Firefox 27.0a2
Firefox 28.0a1

Steps:
1. Load a page (ex: mozilla.org)
2. Save page as pdf.
3. Load another page (ex. webmaker.org)
4. Save page as pdf
5. Check notifications

All download s notifications are well adjust (name, progress) to the correct download.
But:
- Doing twice Save as pdf for osut.org - reproduces the behavior from Comment 0.

Should I close this and open new one with more investigations on that page?

Comment 19

[Aaron Train [:aaronmt]]

Yes, although from your comment it's unclear if this is working. Is this bug fixed?

Comment 20

[Teodora Vermesan (:TeoVermesan)]

Device: LG Nexus 4 (Android 4.2.2)
Builds: Firefox for Android 28.0a1 (2013-12-01) and Firefox for Android 27.0a2 (2013-12-01)
When you perform a download in private tab, the download complete  notification remains in the notification bar.

Comment 21

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Device: Samsung Galaxy Nexus (Android 4.2.1)
Build: Firefox for Android 27.0a2 (2013-12-06)