933775 - Regression: Timestamp on download notifications is false; date stuck in 1970

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Download a file, see notification; see time-stamp from 1970.

Comment 1

[Aaron Train [:aaronmt]]

http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/downloads.js#99 ?

Comment 2

[Federico Paolinelli]

Needs a fix. I might be wrong, but when I implemented this the timestamp was not showing up. Looks like setShowWhen was introduced in api level 17, maybe I was just building against 16?
Anyway, do we want to show here the proper time OR to hide the date as it was before I started messing this whole thing up (:-( ) ?
I will investigate into the cause of the wrong time anyway. The when parameter is necessary in order to preserve the order of the notifications.

Comment 3

[Federico Paolinelli]

Attachment: bug-933775-fix

Comment 4

[Federico Paolinelli]

Forgot to add the comment. In this version I just fixed the time issue, still I am not sure if we want to show the time into the notifications. In the released build we do not have anything like that.

Comment 5

[Federico Paolinelli]

As per the other comment, should we back bug 909932 until we fixed all these issues?

Comment 7

[Aaron Train [:aaronmt]]

Why hasn't this landed?

Comment 8

[Aaron Train [:aaronmt]]

Attachment: 1969.png

Comment 9

[Kevin Brosnan [Ex-Mozilla]]

Adding checkin-needed. Hopefully this applies cleanly.

Comment 10

[Gian-Carlo Pascutto [:gcp]]

Frederico, fix your hg configuration so it adds author information to patches. I checked this in and got set as author because it wasn't set in the patch.

https://hg.mozilla.org/integration/mozilla-inbound/rev/a5f547833e7d1

Comment 11

[Federico Paolinelli]

Damn, thanks for pointing out. It looks like I forgot to readd them after reinstalling the os on my laptop. I am afraid there are some other patches in this state :(

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a5f547833e7d

Comment 13

[Gian-Carlo Pascutto [:gcp]]

Can we get this verified so it can be uplifted?

Comment 14

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 826489 [details] [diff] [review]
bug-933775-fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 909932
User impact if declined: Nonsense download timestamps
Testing completed (on m-c, etc.): On m-c for a few weeks
Risk to taking this patch (and alternatives if risky): Effectively none.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e122fca9e5a4

Comment 16

[Paul Feher]

Verified on Firefox for Android 27 Beta 8
Device:LG Optimus 4X (Android 4.1.2)