921833 - [es-ES] [pt-BR] Twitter link on mozilla.org directs to English Twitter account

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Inma Barrios]

Steps to reproduce:

Click on https://www-demo3.allizom.org/b/es-ES/?v=1
Scroll down the page and click again on the Twitter link

Actual results:
The link directs to the English Twitter account: https://twitter.com/firefox

Expected results:
The link should direct to the Spanish Twitter account: https://twitter.com/firefox_es

Comment 1

[Jennifer Bertsch [:jbertsch]]

Thanks for reporting this, Inma.

Craig and Cmore - Can we make the Twitter link in the footer conditional by locale for Spanish and pt-B and point to our official Spanish and Brazilian Portuguese twitter accounts from there?

* @Firefox https://twitter.com/firefox
* @Firefox_ES https://twitter.com/firefox_es
* @FirefoxBrasil https://twitter.com/firefoxbrasil  

Thanks,
Jen

Comment 2

[Jennifer Bertsch [:jbertsch]]

PS  Please note:  this bug does not block the release of the localized homepage redesign today.

Comment 3

[Craig Cook (:craigcook)]

We can easily make a locale-aware helper like we have for press center links.

Also, this isn't necessarily about the home page -- that link is in the global footer on almost every page.

Comment 4

[Kohei Yoshino [:kohei]]

I have prepared a pull request but still needs approval from the social team in Bug 922373.
https://github.com/kyoshino/bedrock/compare/bug-922373-footer-social

Comment 5

[Kohei Yoshino [:kohei]]

Attachment: Pull Request on GitHub

The change for Bug 922373 has been approved. I sent a pull request combined with this.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/7c58b1d245f1ecdaa6fbedbab9c53df99e6950a4
Merge pull request #1458 from kyoshino/bug-922373-footer-social

Fix Bug 921833 and 922373, footer social links