Closed Bug 921994 Opened 12 years ago Closed 12 years ago

When collection is visible Pagination bar should be hidden

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Everything.me
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: evyatar, Assigned: evyatar)

References

Details

Attachments

(1 file)

Patch - redirect to github PR
234 bytes, text/html
crdlc
: review+
Details
When a collection is opened, it overlays the entire homescreen and the user can't swipe between pages. As a result, the pagination bar is not needed and can be confusing. STR: 1. Open a collection Result: The collection is open, and there's an orange pagination bar at the top. Expected: The pagination bar should be hidden, and brought back when the collection is closed.
Hiding the pagination bar when a collection is open.
Attachment #811904 - Flags: review?(crdlc)
Comment on attachment 811904 [details] Patch - redirect to github PR Important comment on github, thanks a lot
Attachment #811904 - Flags: review?(crdlc) → review-
Status: NEW → ASSIGNED
Oh I completely missed that Object! changed the PR completely, and added the tests. please take another look. thanks!
Attachment #811904 - Flags: review- → review?(crdlc)
Comment on attachment 811904 [details] Patch - redirect to github PR It looks great!! Thanks a lot
Attachment #811904 - Flags: review?(crdlc) → review+
merged to master 172ed15804a768c074e57edeafe589dfdfc48529 https://github.com/mozilla-b2g/gaia/commit/172ed15804a768c074e57edeafe589dfdfc48529
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Blocks: 1.3-e.me
blocking-b2g: --- → koi?
removing koi? since e.me 1.2 features are delayed for future version
blocking-b2g: koi? → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: