If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

When collection is visible Pagination bar should be hidden

RESOLVED FIXED

Status

Firefox OS
Gaia::Everything.me
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Evyatar 'Tron' Amitay (everything.me), Assigned: Evyatar 'Tron' Amitay (everything.me))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

When a collection is opened, it overlays the entire homescreen and the user can't swipe between pages. As a result, the pagination bar is not needed and can be confusing.

STR:
1. Open a collection

Result:
The collection is open, and there's an orange pagination bar at the top.

Expected:
The pagination bar should be hidden, and brought back when the collection is closed.
Created attachment 811904 [details]
Patch - redirect to github PR

Hiding the pagination bar when a collection is open.
Attachment #811904 - Flags: review?(crdlc)
Comment on attachment 811904 [details]
Patch - redirect to github PR

Important comment on github, thanks a lot
Attachment #811904 - Flags: review?(crdlc) → review-
Status: NEW → ASSIGNED
Oh I completely missed that Object! changed the PR completely, and added the tests. please take another look. thanks!
(Assignee)

Updated

4 years ago
Attachment #811904 - Flags: review- → review?(crdlc)
Comment on attachment 811904 [details]
Patch - redirect to github PR

It looks great!! Thanks a lot
Attachment #811904 - Flags: review?(crdlc) → review+
merged to master
172ed15804a768c074e57edeafe589dfdfc48529

https://github.com/mozilla-b2g/gaia/commit/172ed15804a768c074e57edeafe589dfdfc48529
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Blocks: 910302
blocking-b2g: --- → koi?
removing koi? since e.me 1.2 features are delayed for future version
blocking-b2g: koi? → ---
You need to log in before you can comment on or make changes to this bug.