922205 - Columns in MDN redesign are too narrow

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Design, defect)

Description

[Chris Mills [:cmills]]

Attachment: column-narrowing-problem.png

This must have just happened today - the CSS for the columns (classes .column-strip, .column-4) looks to have been changed, as when I set two- and three-column sections on my landing pages, they don't fill up the whole parent container width, and look narrow and squished. See

https://developer.mozilla.org/en-US/docs/Web/Apps
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox_OS

For examples, and see attached screenshot for highlight using the dev tools.

Comment 1

[David Walsh :davidwalsh]

Once this PR is merged (https://github.com/mozilla/kuma/pull/1445), we need to change those "column-strip" elements to "column-third" (i.e. "this column is one-third the total width").

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/c3c7e7db1ee03945ec3303cbaa26f5a2e9eeda4d
Fix bug 922205 - Add new column aliases for common columns

https://github.com/mozilla/kuma/commit/0c17c7fef5f00cc027ebc5f714480fb07a6f4b0b
Merge pull request #1445 from darkwing/new-column-name

Fix bug 922205 - Add new column aliases for common columns

Comment 3

[Chris Mills [:cmills]]

The column-quarter and column-third aliases didn't seem to work when I tried them this morning. I also wanted a column-half alias for two equal columns.

It's no big deal for now. I've changed the three columns to use "column-4" (I didn't understand what that did until now ;-) ), and I've used "column-5" for the two column sections, along with an override in the zone CSS of .column-5 { width: 48.5% }

That's given me what I want for now, but it'd be nice to see this implemented soonish.

Cheers!

Comment 4

[David Walsh :davidwalsh]

So my stuff was merge but not pushed to production  :/   These aliases will be up by end of day, promise.

BTW, "column-half" (alias of "column-6") works right now for your two-column stuff.  Just tried it in production, works great.

Comment 6

[David Walsh :davidwalsh]

This is long done.