Closed Bug 922266 Opened 13 years ago Closed 13 years ago

switch tutorial url decoding from escape to encodeURLComponent

Categories

(Webmaker Graveyard :: Popcorn Maker, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: thecount, Assigned: thecount)

Details

Attachments

(1 external file)

escape is obsolete, we should switch to encodeURIComponent, like bug 918946 is, this way we make a proper match. Escape doesn't seem to be encoding forward slashes, so the two ends are never going to match.
Assignee: nobody → scott
Best to test with bug 918946 checked out for thimble.
Attachment #812206 - Flags: review?(schranz.m)
Attachment #812206 - Flags: review?(schranz.m) → review+
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/1eb51f12a01f2588c65572d4d310b0c3ff40604f I'll mark as verified once the thimble bug lands and we have a less painful tutorial creation process.
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: needinfo?(scott)
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
Status: RESOLVED → VERIFIED
Flags: needinfo?(scott)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: