Closed Bug 918946 Opened 13 years ago Closed 13 years ago

Fix up tutorial UI and dialog

Categories

(Webmaker Graveyard :: Thimble, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: thecount, Assigned: thecount)

Details

(Whiteboard: mozfest)

Attachments

(2 external files)

Right now tutorials are kinda broken. They work if you pass the info right into the project dialog tags, like this: tutorial-urlToProjectWithEscapedColons Need to make this easier. I'm not sure if we need to keep using the meta tag. I doubt it.
Assignee: nobody → scott
Whiteboard: mozfest
So the only broken part about tutorials now is the colon in the tutorial url gets rejected, so we have to encode it. My patch encodes all tags from user input, so they are no considered app tags, and decodes any tags that need to be displayed, so the user never knows this has happened and they happily can use colons in tags now. If a tag is saved inside the make api admin tool by a mentor, we don't encode it, and is dealt with in bug 914786.
Attachment #812172 - Flags: review?(pomax)
I think some clarification is needed. In order to add a tutorial now, you just create a tag like so: "tutorial-url to project" With this landed, the colon in the url is no longer an issue.
If you want to see a tutorial in action on popcorn maker's side, use with bug 922266.
Just noticed another bug while doing the popcorn one. Updated thimble to also properly search for tutorial urls using encodeURLComponent instead of escape.
it feels like this solves a symptom, not a problem, namely: we don't allow ":" in tags except when we do. I would strongly advocate instead allowing ":" in tags with as only restriction that certain prefixes that we have assigned a semantic role already are not user-legal, like "webmaker:" -- then we only need to mark those as bad, client side. If the reason is that MakeAPI does not support tags with ":" in them, then that's a feature incompletion we should solve in the MakeAPI, rather than trying to make the client library circumvent this problem by making it seem like ":" can be used when in fact it cannot be. (having machine tags in makes means that third parties can do magical things with search results from the MakeAPI that we haven't even thought of. They're a universal namespace concept for filtering tags used by Flickr and others for that very purpose) I'm not sure we want to go the route that this patch takes us, so I'd like some more perspective on whether this is the route direction to take our code in.
Flags: needinfo?(david.humphrey)
Flags: needinfo?(cade)
It's been clear for a while that the sweeping ban on Application tags is causing issues. I'm open to change, but it'll be a huge effort to make a change, and one that I don't see happening until post Mozilla Festival. One way I'd like to solve the whole tag problem would be to simply add a write restricted field to Makes that can contain app tags - removing the need to prefix them, and opening up regular tags to use in all kinds of fantasitic ways!
Flags: needinfo?(cade)
Comment on attachment 812172 [details] [review] https://github.com/mozilla/thimble.webmaker.org/pull/240 I'm tentatively okay with this, but this code needs "FIXME" notes and links to bugs that state a need to do this properly instead of temporary fix-ly. r- for the moment, because I'd like to see the code again after those things are added before r+'ing it.
Attachment #812172 - Flags: review?(pomax) → review-
Flags: needinfo?(david.humphrey)
So, once we land this patch, and then later, we fix it, it means we'll have to update any tags that container escaped characters, or else we end up with the same meaning in two spots. Example: Popcorn Maker need to search for projects with the tag "popcorn:maker", it means it also could potentially have to search for "popcorn%3Amaker" because old projects could have this. A real world case of this is the tutorials, right now we know all tutorial links are saved escaped, so we search for them as if they were escaped. If we start saving them not escaped, we end up with the same data in two ways.
I mistakenly staged the commit without the comments: https://github.com/mozilla/thimble.webmaker.org/commit/4d9c718ea804c9c89c0122fe9162015095743484 I made a pull request with the comments.
Attachment #812770 - Flags: review?(pomax)
Comment on attachment 812770 [details] [review] https://github.com/mozilla/thimble.webmaker.org/pull/243 r+ with nits in the PR - basically make the bug mention a real link, and add the FIXME: label a todo/fixme aggregator will find these bits in the code for us.
Attachment #812770 - Flags: review?(pomax) → review+
Attachment #812770 - Flags: review?(pomax) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: needinfo?(scott)
Resolution: --- → FIXED
Attachment mime type: text/plain text/plain → text/x-github-pull-request text/x-github-pull-request
Status: RESOLVED → VERIFIED
Flags: needinfo?(scott)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: