922461 - Fix unused variable warning in <Some IPC Protocol>::CloneManagees()

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Cervantes Yu [:cyu] [:cervantes]]

This is to fix https://bugzilla.mozilla.org/show_bug.cgi?id=771765#c208

Comment 1

[Cervantes Yu [:cyu] [:cervantes]]

Attachment: Fix unused variable warning in CloneManagees()

Comment 2

[Cervantes Yu [:cyu] [:cervantes]]

Try submission: https://tbpl.mozilla.org/?tree=Try&rev=ebbbe31f7e2c

Comment 3

[Daniel Holbert [:dholbert]]

Try looks good, and the patch has r+ - woohoo!

Cervantes, is this ready to be marked checkin-needed, then?

Comment 4

[Cervantes Yu [:cyu] [:cervantes]]

Yes. Sorry for the delay.

Comment 5

[Daniel Holbert [:dholbert]]

No worries! Thanks for fixing it.

Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/14fd6fa23a16

Comment 6

[Daniel Holbert [:dholbert]]

Turns out this doesn't take effect until you clobber (which doesn't really matter, until you have bug 925243's patch as well, asserting that this dir is warning-free).

So, I pushed a CLOBBER tweak for this:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/1a9233d02919

Comment 7

[Daniel Holbert [:dholbert]]

I filed build-config bug 925536 on the fact that this needed a clobber to take effect.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/14fd6fa23a16
https://hg.mozilla.org/mozilla-central/rev/1a9233d02919