Closed Bug 925243 Opened 6 years ago Closed 6 years ago

Mark ipc/ipdl as FAIL_ON_WARNINGS

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

With bug 922461 fixed, ipc/ipdl is warning-free!

Here's a partial try run marking it as FAIL_ON_WARNINGS without bug 922461 (note the linux redness due to warnings, demonstrating that the FAIL_ON_WARNINGS does catch stuff here):
  https://tbpl.mozilla.org/?tree=Try&rev=1f1db1aa6e0a

...and here's an all-platform try run with that plus bug 922461's fix:
 https://tbpl.mozilla.org/?tree=Try&rev=b883699463c4
(Green all around, hurray!)

Let's mark it.
Attached patch fixSplinter Review
Attachment #815248 - Flags: review?(ehsan)
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86_64 → All
Comment on attachment 815248 [details] [diff] [review]
fix

Alternately: khuey, looks like you've reviewed some ipc/ipdl code as well; tagging you in case you get around to signing off on this sooner than ehsan. :)

[I want to land this ASAP, before new warnings are silently introduced.]
Attachment #815248 - Flags: review?
Comment on attachment 815248 [details] [diff] [review]
fix

[er, must've mistyped "khuey"]
Attachment #815248 - Flags: review? → review?(khuey)
Comment on attachment 815248 [details] [diff] [review]
fix

Review of attachment 815248 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay.
Attachment #815248 - Flags: review?(ehsan) → review+
(In reply to comment #3)
> [er, must've mistyped "khuey"]

I do that *all the time*!!!
Comment on attachment 815248 [details] [diff] [review]
fix

Thanks!
Attachment #815248 - Flags: review?(khuey)
It superficially looks like this broke the build, with "unused variable" warnings, but I think those warnings are fixed by the (already-landed) patch for bug 922461, and that patch just needs a clobber to actually take effect.

Testing that theory currently on inbound TBPL.  (but it matches my recollection from local testing yesterday, so I've got a reasonable amount of confidence).

If I turn out to be right, I'll push a followup to touch the CLOBBER file.
Please file a build config bug about the need for clobber here, thanks!
Pushed a CLOBBER tweak, as noted in bug 922461 comment 6. Build config bug coming.
build config bug is bug 925536.
https://hg.mozilla.org/mozilla-central/rev/6df392bd1087
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.