925243 - Mark ipc/ipdl as FAIL_ON_WARNINGS

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Daniel Holbert [:dholbert]]

With bug 922461 fixed, ipc/ipdl is warning-free!

Here's a partial try run marking it as FAIL_ON_WARNINGS without bug 922461 (note the linux redness due to warnings, demonstrating that the FAIL_ON_WARNINGS does catch stuff here):
  https://tbpl.mozilla.org/?tree=Try&rev=1f1db1aa6e0a

...and here's an all-platform try run with that plus bug 922461's fix:
 https://tbpl.mozilla.org/?tree=Try&rev=b883699463c4
(Green all around, hurray!)

Let's mark it.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 815248 [details] [diff] [review]
fix

Alternately: khuey, looks like you've reviewed some ipc/ipdl code as well; tagging you in case you get around to signing off on this sooner than ehsan. :)

[I want to land this ASAP, before new warnings are silently introduced.]

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 815248 [details] [diff] [review]
fix

[er, must've mistyped "khuey"]

Comment 4

[(no longer active)]

Comment on attachment 815248 [details] [diff] [review]
fix

Review of attachment 815248 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay.

Comment 5

[(no longer active)]

(In reply to comment #3)
> [er, must've mistyped "khuey"]

I do that *all the time*!!!

Comment 6

[Daniel Holbert [:dholbert]]

Comment on attachment 815248 [details] [diff] [review]
fix

Thanks!

Comment 7

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6df392bd1087

Comment 8

[Daniel Holbert [:dholbert]]

It superficially looks like this broke the build, with "unused variable" warnings, but I think those warnings are fixed by the (already-landed) patch for bug 922461, and that patch just needs a clobber to actually take effect.

Testing that theory currently on inbound TBPL.  (but it matches my recollection from local testing yesterday, so I've got a reasonable amount of confidence).

If I turn out to be right, I'll push a followup to touch the CLOBBER file.

Comment 9

[(no longer active)]

Please file a build config bug about the need for clobber here, thanks!

Comment 10

[Daniel Holbert [:dholbert]]

Pushed a CLOBBER tweak, as noted in bug 922461 comment 6. Build config bug coming.

Comment 11

[Daniel Holbert [:dholbert]]

build config bug is bug 925536.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6df392bd1087