92253 - Boolean chart makes very wide web pages from query.cgi

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Stephen Lee]

It is difficult to quickly review what is currently in a boolean chart with 
lots of OR operators, as the page generated is too wide to fit in a window. It 
would be more readable if each OR term was on a different row, but more tightly 
packed than the AND terms.

Something roughly along the lines of the way it is shown in queryhelp.cgi.

I patched query.cgi our local bugzilla, and the results seem to look ok to me.

Comment 1

[Stephen Lee]

Attachment: Patch to make complex boolean charts less wide (standard width)

Comment 2

[Dave Miller [:justdave]]

in theory this is good because it makes it fit on the page, however, making this 
change blows away the "obvious order of precidence" and makes the precidence not 
quite so obvious anymore...  (you notice that AND already went below and not next 
to, this is because OR has a higher precidence - with both AND and OR being 
below, it'll be hard to tell which takes higher precidence.

Comment 3

[Dave Miller [:justdave]]

hmm, maybe this will...  AND starts two rows, OR only starts one...   let my 
throw it up somewhere and look at it :)

Comment 4

[Dave Miller [:justdave]]

targetting all bugs with patches so they show up on the radar.

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

Mass moving to new product Bugzilla...

Comment 6

[Gervase Markham [:gerv]]

I think we don't want to do it the way this patch does it; removing patch
keyword until Dave thinks of a better solution.

Gerv

Comment 7

[Stephen Lee]

Attachment: Example of how boolean chart looks with above patch applied

Just to remove ambiguity, this is how the boolean chart actually looks with
this patch applied. Note that the precedence of AND and OR is still clear, but
the page is all viewable at once.

Comment 8

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 9

[Bradley Baetz (:bbaetz)]

Comment on attachment 43520 [details] [diff] [review]
Patch to make complex boolean charts less wide (standard width)

this won't apply due to templatisation.

justdave: You never followed up your comment #3 about whether or not you wanted
this.

Comment 10

[Dave Miller [:justdave]]

What I said was "let's throw this up somewhere and see what it looks like."  Now
we don't have a patch that applies so I can't throw it up somewhere.  However,
Stephen was kind enough to post an HTML mockup, and I really like the way it
works.  Now we just need to get a patch that applies to the tip.

Comment 11

[Stephen Lee]

Attachment: Patch V2: Hand-written - based on 2.16 template

Glancing at the current code, I'd suggest that this would be done in the
template as in the attached hand-written patch.

I checked the patch applies, but since I don't have 2.16 up and running yet, I
can't verify the functionality. Seems straightforward enough that there can't
possibly be any errors though........

Comment 12

[Stephen Lee]

Attachment: Patch V3: Fixes a blocking regression.

Found this didn't work when first applied...

... then noticed that I was getting lots of [Or] buttons rather than the Or
text, because the conditional test in the template is wrong.

This patch fixes that fault (and also the same thing with the [And] buttons) as
well as modifying the layout. Modified layout is essentially the same as in
attachment 57575 [details].

Comment 13

[Gervase Markham [:gerv]]

Attachment: Patch v.4

Never has such a small tweak produced such a big UI improvement.

This applies to the tip.

Gerv

Comment 14

[Gervase Markham [:gerv]]

myk, dave: is this worth checking in now? It really improves the UI, and it's a
six-character change :-)

Gerv

Comment 15

[Dave Miller [:justdave]]

Comment on attachment 105648 [details] [diff] [review]
Patch v.4

I had my doubts at first, but the positioning of the word "And" is enough
different that it still makes it clear that the entire group of ORs is lumped
together before the AND.

r= justdave
a= justdave

Comment 16

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/search/boolean-charts.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/boolean-charts.html.tmpl,v
 <--  boolean-charts.html.tmpl
new revision: 1.3; previous revision: 1.2
done

Gerv