922614 - Newsgroup: should not be displayed only if there is no newsgroup account defined in the TB profile

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[:aceman]

Bug 399446 made it so the Newsgroup addressee type is not offered if a News account is not selected as the From identity in compose window. However, there are usecases where it should be possible to choose a Mail account as From and still post to an email address and a Newsgroup.

+++ This bug was initially created as a clone of Bug #399446 comment 35 +++

 Magnus Melin 2013-09-30 19:58:30 CEST

It's visible (Newsgroup option on address widget) if you're writing from a newsgroup account (and you can temporarily switch to one). Granted, i agree this makes mail+news postings very difficult. Would be better if it hid depending on the presence of a newsgroup account.

Comment 1

[:aceman]

Attachment: patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 812763 [details] [diff] [review]
patch

Review of attachment 812763 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM! r=mkmelin

::: mail/components/compose/content/MsgComposeCommands.js
@@ +3769,5 @@
> +    if (account.incomingServer.type == "nntp")
> +      hideNews = false;
> +  }
> +  // If there is no News (NNTP) account existing then
> +  // hide the Newsgroup recipient type in all the menulists

and Followup-To.

@@ +3771,5 @@
> +  }
> +  // If there is no News (NNTP) account existing then
> +  // hide the Newsgroup recipient type in all the menulists
> +  // as it is not possible to send to a newsgroup (independent on which
> +  // account was actually chosen as the From).

Not sure what this comment means.

The idea is that we need to know which news server to post the message to, and if you haven't set up any account we're lost.

Comment 3

[:aceman]

Attachment: patch v2

Ok, thanks.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/d65201425440

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Backed out for mozmill failures.
https://hg.mozilla.org/comm-central/rev/b970eb341906

https://tbpl.mozilla.org/php/getParsedLog.php?id=28752198&tree=Thunderbird-Trunk

Comment 6

[:aceman]

Attachment: patch v3 with test fix

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 814508 [details] [diff] [review]
patch v3 with test fix

Review of attachment 814508 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin

::: mail/test/mozmill/composition/test-address-widgets.js
@@ +137,5 @@
> +
> +  // Now the NNTP account is lost, so we should be back to mail only addressees.
> +  be_in_folder(accountPOP3.incomingServer.rootFolder);
> +  cwc = open_compose_new_mail();
> +  allowed_mail_types();

Could you also before this add some check that there are only mail accounts set up?

Could you rename allowed_mail_types to something more telling, like checkMailAddressTypes, and allowed_nntp_types to checkNNTPAddressTypes?

Comment 8

[:aceman]

Attachment: patch v4 with test fix

Thanks, done.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/92ae5415cfbe

Comment 10

[Ryan VanderMeulen [:RyanVM]]

This was backed out and later relanded while investigating a test failure.
https://hg.mozilla.org/comm-central/rev/8dff78580066

Comment 11

[:aceman]

Comment on attachment 815082 [details] [diff] [review]
patch v4 with test fix

[Approval Request Comment]
Regression caused by (bug #): bug 399446
User impact if declined: inability to send from a mail account to mail & news addresses
Testing completed (on c-c, etc.): c-c trunk
Risk to taking this patch (and alternatives if risky): another regression we don't see yet.

Comment 12

[Mark Banner (:standard8)]

Comment on attachment 815082 [details] [diff] [review]
patch v4 with test fix

[Triage Comment]
Needs landing on aurora/beta first.

Comment 13

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-aurora/rev/a3d41f6a59fc
https://hg.mozilla.org/releases/comm-beta/rev/2c4f80ad6538

Comment 14

[Mark Banner (:standard8)]

https://hg.mozilla.org/releases/comm-esr24/rev/681b0f89f849