922618 - Collection edit-mode not working properly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Evyatar 'Tron' Amitay (everything.me)]

1. Shake animation doesn't work
2. Clicking the Remove button doesn't work, instead it triggers a normal click action

STR:
1. Open a collection
2. Long-tap one of the pinned apps (apps above the line)
3. Tap the Remove button

Result:
The icons don't display the same animation as the homescreen grid.
Tapping the Remove button doesn't remove the app. instead it launches it.

Expected:
The icons should pulsate like the homescreen icons in edit mode.
Tapping the Remove button should remove the app.

Comment 1

[Evyatar 'Tron' Amitay (everything.me)]

Attachment: Patch - redirect to github PR

Comment 2

[Cristian Rodriguez (:crdlc)]

Comment on attachment 812626 [details]
Patch - redirect to github PR

I added dragdrop.css when we are in edit mode so I broke it thought :)

Comment 3

[Cristian Rodriguez (:crdlc)]

Please add dependencies to bug

Comment 4

[Evyatar 'Tron' Amitay (everything.me)]

yeah it's the lazy load :) do you know its bug ID?
anyway the lazy-load is already in master, so there's no real dependency - this could (and should) be merged directly to master.

Comment 5

[Cristian Rodriguez (:crdlc)]

Added dependency to bug 916690

Comment 6

[Evyatar 'Tron' Amitay (everything.me)]

landed on master
372042a09b17a61a0b428b20ccbe98654c6a78f1

https://github.com/mozilla-b2g/gaia/commit/372042a09b17a61a0b428b20ccbe98654c6a78f1

Comment 8

[Evyatar 'Tron' Amitay (everything.me)]

removing koi? since e.me 1.2 features are delayed for future version