Closed
Bug 92274
Opened 23 years ago
Closed 16 years ago
email_in.pl using the From address doesn't work with emailsuffix
Categories
(Bugzilla :: Incoming Email, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: bedge, Assigned: LpSolit)
References
Details
Attachments
(1 file)
739 bytes,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
The distributed bug_email.pl does not deal with local user names. It requires a complete domain name. Also, if the assigned_to field is omitted from an email, it is not gnerated correctly. Here is the diff to fix both issues: diff bug_email.pl.orig bug_email.pl 91a92 > my $EmailSender; 444c445 < Reply( $SenderShort, $Message_ID, "Bugzilla Error", "Permission denied.\n\n" . --- > Reply( $EmailSender, $Message_ID, "Bugzilla Error", "Permission denied.\n\n" . 760a762 > $EmailSender = $SenderShort; 952c954 < $Control{'assigned_to'} = DBname_to_id($Control{'assigned_to'}, $forceAssignedOK); --- > # Already a number !! $Control{'assigned_to'} = DBname_to_id($Control{'assigned_to'}, $forceAssignedOK); 1267c1269 < Reply( $SenderShort, $Message_ID,"Bugzilla success (ID $id)", $reply ); --- > Reply( $EmailSender, $Message_ID,"Bugzilla success (ID $id)", $reply ); 1282c1284 < Reply( $SenderShort, $Message_ID, "Bugzilla Error", $errreply ); --- > Reply( $EmailSender, $Message_ID, "Bugzilla Error", $errreply );
Updated•22 years ago
|
Target Milestone: --- → Bugzilla 2.18
Comment 1•22 years ago
|
||
-> Bugzilla product
Component: Bugzilla → Bugzilla-General
Product: Webtools → Bugzilla
Version: Bugzilla 2.12 → 2.12
Comment 2•22 years ago
|
||
When setting up the mail interface in conjunction with local user names (restricting access to Bugzilla by automatically adding "@domain.tl"), I stumbled over this issue. The version I'm using is Bugzilla 2.14.1. The diff from the description didn't completely solve the problem - maybe version dependent. For me, the follwoing seems to work: diff bug_email.pl bug_email.pl.orig 92d91 < my $EmailSender; 445c444 < Reply( $EmailSender, $Message_ID, "Bugzilla Error", "Permission denied.\n\n" . --- > Reply( $SenderShort, $Message_ID, "Bugzilla Error", "Permission denied.\n\n" . 763,765d761 < $EmailSender = $SenderShort; < print "EmailSender = $EmailSender\n"; < 838c834 < if (! CheckPermissions("CreateBugs", $EmailSender ) ) { --- > if (! CheckPermissions("CreateBugs", $SenderShort ) ) { 1260c1256 < Reply( $EmailSender, $Message_ID,"Bugzilla success (ID $id)", $reply ); --- > Reply( $SenderShort, $Message_ID,"Bugzilla success (ID $id)", $reply ); 1275c1271 < Reply( $EmailSender, $Message_ID, "Bugzilla Error", $errreply ); --- > Reply( $SenderShort, $Message_ID, "Bugzilla Error", $errreply );
Comment 3•22 years ago
|
||
Just a heads up: the above diff is backwards.
Updated•21 years ago
|
OS: Linux → All
Hardware: PC → All
Whiteboard: bug_email
Updated•21 years ago
|
Blocks: bz-email-in
Comment 4•21 years ago
|
||
CCing Dan Berlin, who from stuff I've seen around, I know is actually using the bug_email stuff. I'd appreciate any input or fixes you'd be willing to provide on these bugs :-)
Comment 5•20 years ago
|
||
I'm not sure I follow what the provided diff is trying to accomplish... but that file is pretty ugly anyway.
Assignee: justdave → nobody
Target Milestone: Bugzilla 2.18 → Bugzilla 2.20
Updated•19 years ago
|
Target Milestone: Bugzilla 2.20 → Future
Updated•18 years ago
|
No longer blocks: bz-email-in
Updated•18 years ago
|
QA Contact: mattyt-bugzilla → default-qa
Updated•17 years ago
|
Target Milestone: Future → ---
![]() |
Assignee | |
Updated•16 years ago
|
Assignee: nobody → LpSolit
Component: Bugzilla-General → Incoming Email
Whiteboard: bug_email
Target Milestone: --- → Bugzilla 3.0
![]() |
Assignee | |
Comment 7•16 years ago
|
||
Copying the bug summary of bug 396692, which is much more explicit.
Summary: bug_email.pl, assigned_to generation and local addresses → email_in.pl using the From address doesn't work with emailsuffix
![]() |
Assignee | |
Comment 8•16 years ago
|
||
Attachment #311484 -
Flags: review?(mkanat)
Comment 9•16 years ago
|
||
Comment on attachment 311484 [details] [diff] [review] patch, v1 Yeah, that looks right to me.
Attachment #311484 -
Flags: review?(mkanat) → review+
Updated•16 years ago
|
Flags: approval3.0+
Flags: approval+
![]() |
Assignee | |
Comment 10•16 years ago
|
||
tip: Checking in email_in.pl; /cvsroot/mozilla/webtools/bugzilla/email_in.pl,v <-- email_in.pl new revision: 1.15; previous revision: 1.14 done 3.0.3: Checking in email_in.pl; /cvsroot/mozilla/webtools/bugzilla/email_in.pl,v <-- email_in.pl new revision: 1.5.2.9; previous revision: 1.5.2.8 done
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•