Closed
Bug 922971
Opened 11 years ago
Closed 11 years ago
API calls infinite retries
Categories
(Firefox OS Graveyard :: Gaia::Everything.me, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evyatar, Assigned: evyatar)
References
Details
Attachments
(1 file)
If something's gone wrong, the API will infinitely retry. There should be a limit to the number of retries per request (3 requests max).
|
Assignee | |
Comment 1•11 years ago
|
||
In addition, if the API is retrying, calling "abort" on the request doesn't really stop it.
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #812998 -
Flags: review?(ran)
Attachment #812998 -
Flags: review?(crdlc)
|
|
Assignee | |
Comment 3•11 years ago
|
||
I fixed some whitespacing issues, so to see the changes more clearly please use the w=1 flag
https://github.com/mozilla-b2g/gaia/pull/12605/files?w=1
|
||
Comment 4•11 years ago
|
||
Comment on attachment 812998 [details]
Patch - redirect to github PR
I don't know this part :(, with Ran's review is enough here thought
Attachment #812998 -
Flags: review?(crdlc)
|
|
Assignee | |
Comment 5•11 years ago
|
||
just wanted you to be proud there are no anonymous functions ;)
|
||
Updated•11 years ago
|
Attachment #812998 -
Flags: review?(ran) → review+
|
|
||
Comment 7•11 years ago
|
||
Always good to see improvements in AI requests. It seems to have solved an "fast typing" request abort bug we had as well.
Flags: needinfo?(evyatar)
|
|
Assignee | |
Comment 8•11 years ago
|
||
merged into master
45ed500c5cb67064fb33be3517366972b674e81c
https://github.com/mozilla-b2g/gaia/commit/45ed500c5cb67064fb33be3517366972b674e81c
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
||
Updated•11 years ago
|
blocking-b2g: --- → koi?
|
||
Comment 9•11 years ago
|
||
Clearing nom - we're no longer taking e.me 1.2 feature changes to 1.2.
blocking-b2g: koi? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•