Closed Bug 922983 Opened 11 years ago Closed 11 years ago

[Flatfish][notificaiton] time on the top left corner is fixed

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set
normal

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

RESOLVED FIXED
blocking-b2g koi+
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: atsai, Assigned: gduan)

References

Details

(Whiteboard: [flatfishRun1, Flatfish only])

Attachments

(2 files)

Attached image fixed-time.png
[Environment]
DuT:      Flatfish
Gaia:     def8e152db6a317162c03a316f68c409f3af3979
Gecko:    6ae6fea8d39011d1f9abfdb334ca800bfd5b5227
Gecko after patch: 9eedb6201641498fee3fcc654100058ca404ac40
Blocks: flatfish
QA Contact: atsai
Whiteboard: flatfishRun1
Please notification bar and lockscreen don't belongs to homescreen app, thanks
Component: Gaia::Homescreen → Gaia::System
blocking-b2g: --- → koi+
Whiteboard: flatfishRun1 → [flatfishRun1, Flatfish only]
Hi Al,
do you mean the second doesn't increase?
Flags: needinfo?(atsai)
Exactly. The seconds doesn't increase. Is that part of design?
Flags: needinfo?(atsai)
(In reply to Al Tsai [:atsai] from comment #3)
> Exactly. The seconds doesn't increase. Is that part of design?

More information for your reference, I tested on the buri devices. There's only date in the corner, and the date changes while cross 12:00a.m.. My question is that date and time displayed in the corner is a design for flatfish.
It's common issue on every platform when you switch language to Chinese.
It's a one line fix if we don't need to display the "second" part, but I'd like to make sure what to display with UX team (maybe l10n?)

Hi Mike,
as you can see the status bar in the attachment, the 'second' part wouldn't update itself til one minute only in Chinese language. However, other language actually don't have the 'second' part and so does our current code (time update by 60 seconds). Do you think it's ok to only display month and date as other language? If so, what format should be ok? like 10月, 6日?
Flags: needinfo?(mtsai)
Hi George, here is my suggestion :
When user pull down the notification bar, keep the date information on the top row,
and at the same time hide/cover status bar. User can scroll up notification bar easily at anytime to see status bar.
It's a simple and reasonable solution.
Flags: needinfo?(mtsai)
Hi George, per talk. I will file another bug for information overlapping issue.
For current implementation. Please just show date when notification is dragged out.
Don't show time since time is always available on the right side of status abr.
Thank you.
Attached file PR to master
Hi Alive,
per offline discussing with Mike, we'll use the format as my patch.
Please kindly help to review it, thanks.
Attachment #816469 - Flags: review?(alive)
Question: how about other languages?
Other languages are fine (fr, ar, en-US), they use %e %b. Only zh-tw is different which display hr + min + sec (%c).
Assignee: nobody → gduan
Flags: needinfo?(alive)
OK, I just want to make sure UX sign off this.

(In reply to George Duan [:gduan] from comment #10)
> Other languages are fine (fr, ar, en-US), they use %e %b. Only zh-tw is
> different which display hr + min + sec (%c).
Flags: needinfo?(alive)
Comment on attachment 816469 [details]
PR to master

Hi pike or stas, I don't know if we need to get attention on this kind of l10n change so I just flag you two.
Attachment #816469 - Flags: review?(alive)
Attachment #816469 - Flags: review+
Attachment #816469 - Flags: feedback?(stas)
Attachment #816469 - Flags: feedback?(l10n)
Comment on attachment 816469 [details]
PR to master

We don't maintain the localizations in the gaia repo itself. The localizations are in hg, for example in http://hg.mozilla.org/gaia-1l0n/zh-TW/.

That has 

statusbarLabel={{date}}, {{operator}}
statusbarDateFormat=%b %e 日
statusbarTimeFormat=%I:%M

I.e. the content you expect.

If you uplift this particular fix into gaia, I don't mind much.
Attachment #816469 - Flags: feedback?(stas)
Attachment #816469 - Flags: feedback?(l10n)
Thanks, 
merge into master,
https://github.com/mozilla-b2g/gaia/commit/cf912b3ef234bff03f91e57e182a2982271f0acf
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Uplifted cf912b3ef234bff03f91e57e182a2982271f0acf to:
v1.2: f081095b98fff4d91f18b336fcf855c1b4a6c47b
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: