923040 - [Flatfish][Gaia] Can not remove default of Cost Control app

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[OrsonHsueh]

ENVIRONMENT:
userdebug build [ VARIANT=userdebug ]
commit 90e78f2744412abf3a57d4d4fe981d662203d93a
Date:   Tue Oct 1 21:00:40 2013 -0700

STEP:
In gaia directory,enter the following command:
make clean
mv apps/costcontrol/ /tmp
make

EXPECTED:
Can remove costcontrol App.
Want to update the default App for Tablet.


ACTUAL:
make error log:
Invalid JSON file : /home/orson/Project/F1/New/a31-b2g/gaia/apps/costcontrol/update.webapp
Exception: Error:  -*- build/utils.js: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFileInputStream.init]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/orson/Project/F1/New/a31-b2g/gaia/build/utils.js :: getFileContent :: line 43"  data: no]
file not found: /home/orson/Project/F1/New/a31-b2g/gaia/apps/costcontrol/update.webapp

getFileContent@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/orson/Project/F1/New/a31-b2g/gaia/build/utils.js:59
getJSON@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/orson/Project/F1/New/a31-b2g/gaia/build/utils.js:110
getIconInfo@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/orson/Project/F1/New/a31-b2g/gaia/build/applications-data.js:101
iconDescriptor@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/orson/Project/F1/New/a31-b2g/gaia/build/applications-data.js:119

Comment 1

[Andrew McCreight [:mccr8]]

This does not sound like a security issue.

Comment 2

[[e-mail]]

it should not have costcontrol app on tablet

please use build script described in bug 903304 Comment 7 (note the command will be changed soon, please refer back to find the latest command) to run with tablet customization 

`GAIA_DISTRIBUTION_DIR=distribution_tablet MOZILLA_OFFICIAL=1 GAIA_DEV_PIXELS_PER_PX=1.5 make production`

Comment 3

[OrsonHsueh]

Hi Fred Lin,

one question,
Gaia default app only cover, but can not delete it?
Right ?

Thanks.

Comment 4

[[e-mail]]

OrsonHsueh, 

We can't delete default app if you use `make production` command, which will flash build-in apps into un-rewritable section.

Once you long touch on app icon in homescreen, the red cross icon(means deletable) in top left should not be shown

Comment 5

[Francis Lee [:frlee]]

It's a must for flatfish. Marked as koi+ according to triage result.
flatfish only supports wifi and there's no modern in the flatfish. its not reasonable to build-in cost control app.

Comment 6

[OrsonHsueh]

Hi Fred Lin,

OK. I see.
Thanks for prompt response.

I tested the following command:
`GAIA_DISTRIBUTION_DIR=distribution_tablet MOZILLA_OFFICIAL=1 GAIA_DEV_PIXELS_PER_PX=1.5 make production`

Did not find CostControl app, thanks!

I think this bug should have been corrected, do you think?

Comment 7

[[e-mail]]

Yes, mark as resolved