923393 - Cannot drag apps or bookmarks with an icon by default

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Cristian Rodriguez (:crdlc)]

If an icon has not an icon and it shows one by default, we can't drag this app or bookmark

Comment 1

[Cristian Rodriguez (:crdlc)]

When I say: "If an icon has not an icon" I mean when an app or bookmark has not an image icon :)

Comment 2

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

We removed the renderedIcon when it is by default from the descriptor then the loadRenderedIcon method fails, so if the renderedIcon is not defined we recover the icon by default blob calling to GridManager.getBlobByDefault

Comment 3

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/8d268639b5a4708285b0714d8cf6f8dc2def6ac4

Comment 4

[bhavana bajaj [:bajaj]]

This is not a blocker issue but something that should have got fixed uplifted before 10/28 when approvals were being granted given its a regression.

Comment 6

[Julien Wajsberg [:julienw] (PTO -> Dec 30)]

This is a quite serious regression (see bug 951971 for a STR from a partner) and it should have been uplifted to v1.2 back at the time.

Requesting koi now, I know it's late. I don't understand why koi? was not asked when leo? was rejected, it should be the normal process.

Comment 7

[Jason Smith [:jsmith]]

Too late for 1.2 at this point & this is not a regression from 1.1, so this is not a blocker for 1.2.

Comment 8

[Julien Wajsberg [:julienw] (PTO -> Dec 30)]

I find this is a pity that such a small patch can't be uplifted to 1.2, especially that it's in 1.3 for 2 months without regression.

Comment 9

[bhavana bajaj [:bajaj]]

Was never a blocker given the STR we had in this bug, neither was this ready in time when approvals were given in 1.2 timeframe. Also QA highlighted that this is not a regression from 1.1.