923483 - [B2G][Everything.me] An app removed from the top of a collection cannot be added again until re-entering the collection

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Matthew Vaughan]

Attachment: Video showing a removed app triggering edit mode for other apps.

Description:
When an app is removed from the top of a collection, the user is unable to add the app to the top of the collection again until they exit and then re-enter the collection. If the user attempts to add the app to the top of the collection again, it will instead trigger edit mode for the apps that are currently at the top of the collection.

Repro Steps:
1) Update Buri to Build ID: 20131003040204
2) Boot device to Homescreen
3) Tap on the Social collection icon to enter it
4) Long tap the Facebook icon
5) Select "Add to top of collection"
6) Long tap the Facebook icon to trigger edit mode
7) Tap the remove button in upper left corner of the icon (red with white "x")
8) Tap the Home button to exit edit mode
9) Long tap the Facebook icon

Actual:
Edit mode is triggered for the apps at the top of the collection.

Expected:
Context menu with the option "Add to top of collection" appears.

Environmental Variables
Device: Buri
Build ID: 20131003040204
Gecko: http://hg.mozilla.org/mozilla-central/rev/0e26e6f12ad9
Gaia: dc68f530ca7d1b182deef0a3787cfdd8f0778612
Platform Version: 27.0a1
RIL Version: 01.02.00.019.062 

Notes:
Repro frequency: 100%
See attached: AddToTopOfCollection.mp4 & logcat.txt
Workaround: As mentioned, if the user exits and then re-enters the collection, they will be able to add the app to the top of the collection again.

Comment 1

[Matthew Vaughan]

Attachment: LogCat of adding and removing app from top of collection, and triggering edit mode for other apps.

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Nice catch! On it.

Comment 3

[Amir Nissim (:amirn)]

Attachment: redirect to PR 12657.html

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

Landed in master
https://github.com/mozilla-b2g/gaia/commit/86b252b5ba3dc6d4b4cc145e10efbbba3cff9209

Comment 5

[Matthew Vaughan]

This is verified fixed in the 10/04/13 1.3 master build. User is now able to remove more than one app from the top of a collection without having to exit and re-enter it.

Environmental Variables
Device: Buri
Build ID: 20131004040203
Gecko: http://hg.mozilla.org/mozilla-central/rev/8f08240128c8
Gaia: 1ac6749e36424124493a1b4c7534f298789bdffd
Platform Version: 27.0a1

Comment 6

[Evyatar 'Tron' Amitay (everything.me)]

removing koi? since e.me 1.2 features are delayed for future version