923692 - [B2G][Everything.me] The home button does not take the user back to the homescreen when naming a collection

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: NameCollection.mp4

Description:
The home button does not take the user back to the homescreen when naming a collection. The user can see the screen go to the homescreen in the background behind the overlay.

Repro Steps:
1)  Updated Buri Build ID: 20131004040203
2)  Long press on an empty part of the homescreen and tap on "Add Collection".
3)  Tap on "Custom".
4)  While on the "Create your own collection" overlay, tap the "Home Button" on the phone.

Actual:
The user is not taken home when the press the "Home Button" on the phone while the "Create your own collection" overlay is on the screen.

Expected:
The user is returned to the homescreen.

Environmental Variables
Device: Buri v 1.3.0 Mozilla RIL
Build ID: 20131004040203
Gecko: http://hg.mozilla.org/mozilla-central/rev/8f08240128c8
Gaia: 1ac6749e36424124493a1b4c7534f298789bdffd
Platform Version: 27.0a1
RIL Version: 01.02.00.019.056 

Notes:
Repro frequency: 100%
See attached: video clip

Comment 1

[Jason Smith [:jsmith]]

Home button always needs to work. If anything is breaking it, it's a blocker.

Comment 2

[Evyatar 'Tron' Amitay (everything.me)]

Isn't this a system issue? a standard "prompt" is opened there.
I believe that the home button shouldn't report anything to the code if there's a prompt open, but instead simply close it and return 'false'.

Comment 3

[Amir Nissim (:amirn)]

As Evyatar mentioned, we are using a standard system prompt which is not hidden when tapping the home button.

It seems that other apps (System and Browser) have implemented a ModalDialog object for displaying alert/confirm/prompt alternatives within the apps. None of the two implementations is reusable by other apps.

Crisitan - how should we proceed?
1. fix this at the system level
2. implement yet another custom prompt for the 'homescreen' app
3. make a shared ModalDialog object

Comment 4

[Cristian Rodriguez (:crdlc)]

The approach is between 2 and 3 options. There is a custom dialog in shared 

https://github.com/mozilla-b2g/gaia/blob/master/shared/js/custom_dialog.js

Comment 5

[Amir Nissim (:amirn)]

(In reply to Cristian Rodriguez (:crdlc) from comment #4)
> The approach is between 2 and 3 options. There is a custom dialog in shared 
> 
> https://github.com/mozilla-b2g/gaia/blob/master/shared/js/custom_dialog.js

the shared CustomDialog does not support prompt. Do you mean we should modify it?

Comment 6

[Cristian Rodriguez (:crdlc)]

Better implement a prompt ui in home with lazy DOM ...

Comment 7

[Jason Smith [:jsmith]]

No longer uplifting any e.me 1.2 features to 1.2, so clearing nom.

Comment 8

[Ran Ben Aharon [:ranbena] EverythingMe]

Gregor, is there any progress with this?

Comment 9

[Gregor Wagner [:gwagner]]

(In reply to Ran Ben Aharon (Everything.me) from comment #8)
> Gregor, is there any progress with this?

Thanks for the ping. We lost track of it.
So collections are now in 1.3 and this is a bug in 1.3 right?

BTW, do you know of any other e.me related bugs that need our attention?

Comment 10

[Ran Ben Aharon [:ranbena] EverythingMe]

Yes Collections are intended for 1.3.
I don't know of any other system related bugs. Thanks!

Comment 11

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Cristian, do you have bandwidth to take this?

Comment 12

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Changing back to unassigned 'cause, well, it's unassigned.

Comment 13

[Cristian Rodriguez (:crdlc)]

Hi, I cannot work on it because I am working in the download manager, please could Evyatar take a look to this one? ot you? 10x

(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #11)
> Cristian, do you have bandwidth to take this?

Comment 14

[Ran Ben Aharon [:ranbena] EverythingMe]

Guys, this is a system bug. Referring to comment 2.

Comment 15

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

This patch allows users to close modal dialog when the homescreen is displayed clicking on home button

Comment 16

[Ran Ben Aharon [:ranbena] EverythingMe]

Works great :)

Comment 17

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8338373 [details]
Patch v1

r=me

Comment 18

[(inactive after 6/18) Alive Kuo [:alive]]

Side note: After bug 907013 lands we don't need this check-age anymore.

Comment 19

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Alive Kuo [:alive][NEEDINFO] from comment #18)
> Side note: After bug 907013 lands we don't need this check-age anymore.

Oh ignore last comment...after bug 907013 lands we need to do something in HomescreenWindow or HomescreenLauncher to 'dismiss modal dialog when home button is clicked on homescreen'. I will do this then.

Comment 20

[Cristian Rodriguez (:crdlc)]

Hi Alive, do I have to land this one or close as dup? Thanks Alive

Comment 21

[(inactive after 6/18) Alive Kuo [:alive]]

Land it first since it's 1.3+!

Comment 22

[Cristian Rodriguez (:crdlc)]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/651cd7ade606e4b487d51bf009225a69c501bd55