Closed Bug 923692 Opened 11 years ago Closed 11 years ago

[B2G][Everything.me] The home button does not take the user back to the homescreen when naming a collection

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:1.3+)

RESOLVED FIXED
1.3 Sprint 6 - 12/6
blocking-b2g 1.3+

People

(Reporter: KTucker, Assigned: crdlc)

References

Details

(Whiteboard: [e.me 1.2 test run][systemsfe])

Attachments

(2 files)

Attached video NameCollection.mp4
Description:
The home button does not take the user back to the homescreen when naming a collection. The user can see the screen go to the homescreen in the background behind the overlay.

Repro Steps:
1)  Updated Buri Build ID: 20131004040203
2)  Long press on an empty part of the homescreen and tap on "Add Collection".
3)  Tap on "Custom".
4)  While on the "Create your own collection" overlay, tap the "Home Button" on the phone.

Actual:
The user is not taken home when the press the "Home Button" on the phone while the "Create your own collection" overlay is on the screen.

Expected:
The user is returned to the homescreen.

Environmental Variables
Device: Buri v 1.3.0 Mozilla RIL
Build ID: 20131004040203
Gecko: http://hg.mozilla.org/mozilla-central/rev/8f08240128c8
Gaia: 1ac6749e36424124493a1b4c7534f298789bdffd
Platform Version: 27.0a1
RIL Version: 01.02.00.019.056 

Notes:
Repro frequency: 100%
See attached: video clip
Blocks: 1.3-e.me
Home button always needs to work. If anything is breaking it, it's a blocker.
blocking-b2g: --- → koi?
Component: Gaia::Everything.me → Gaia::Homescreen
Assignee: nobody → amirn
Status: NEW → ASSIGNED
Isn't this a system issue? a standard "prompt" is opened there.
I believe that the home button shouldn't report anything to the code if there's a prompt open, but instead simply close it and return 'false'.
As Evyatar mentioned, we are using a standard system prompt which is not hidden when tapping the home button.

It seems that other apps (System and Browser) have implemented a ModalDialog object for displaying alert/confirm/prompt alternatives within the apps. None of the two implementations is reusable by other apps.

Crisitan - how should we proceed?
1. fix this at the system level
2. implement yet another custom prompt for the 'homescreen' app
3. make a shared ModalDialog object
Flags: needinfo?(crdlc)
Component: Gaia::Homescreen → Gaia::System
The approach is between 2 and 3 options. There is a custom dialog in shared 

https://github.com/mozilla-b2g/gaia/blob/master/shared/js/custom_dialog.js
Flags: needinfo?(crdlc)
(In reply to Cristian Rodriguez (:crdlc) from comment #4)
> The approach is between 2 and 3 options. There is a custom dialog in shared 
> 
> https://github.com/mozilla-b2g/gaia/blob/master/shared/js/custom_dialog.js

the shared CustomDialog does not support prompt. Do you mean we should modify it?
Better implement a prompt ui in home with lazy DOM ...
Whiteboard: [e.me 1.2 test run] → [e.me 1.2 test run][systemsfe]
Assignee: amirn → nobody
No longer uplifting any e.me 1.2 features to 1.2, so clearing nom.
blocking-b2g: koi? → ---
Gregor, is there any progress with this?
Flags: needinfo?(anygregor)
(In reply to Ran Ben Aharon (Everything.me) from comment #8)
> Gregor, is there any progress with this?

Thanks for the ping. We lost track of it.
So collections are now in 1.3 and this is a bug in 1.3 right?

BTW, do you know of any other e.me related bugs that need our attention?
blocking-b2g: --- → 1.3?
Flags: needinfo?(anygregor)
Target Milestone: --- → 1.3 Sprint 6 - 12/6
blocking-b2g: 1.3? → 1.3+
Yes Collections are intended for 1.3.
I don't know of any other system related bugs. Thanks!
Cristian, do you have bandwidth to take this?
Flags: needinfo?(crdlc)
Changing back to unassigned 'cause, well, it's unassigned.
Status: ASSIGNED → NEW
Hi, I cannot work on it because I am working in the download manager, please could Evyatar take a look to this one? ot you? 10x

(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #11)
> Cristian, do you have bandwidth to take this?
Flags: needinfo?(crdlc)
Guys, this is a system bug. Referring to comment 2.
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Attached file Patch v1
This patch allows users to close modal dialog when the homescreen is displayed clicking on home button
Attachment #8338373 - Flags: review?(21)
Works great :)
Comment on attachment 8338373 [details]
Patch v1

r=me
Attachment #8338373 - Flags: review?(alive) → review+
Side note: After bug 907013 lands we don't need this check-age anymore.
(In reply to Alive Kuo [:alive][NEEDINFO] from comment #18)
> Side note: After bug 907013 lands we don't need this check-age anymore.

Oh ignore last comment...after bug 907013 lands we need to do something in HomescreenWindow or HomescreenLauncher to 'dismiss modal dialog when home button is clicked on homescreen'. I will do this then.
Hi Alive, do I have to land this one or close as dup? Thanks Alive
Flags: needinfo?(alive)
Land it first since it's 1.3+!
Flags: needinfo?(alive)
Landed in master:

https://github.com/mozilla-b2g/gaia/commit/651cd7ade606e4b487d51bf009225a69c501bd55
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: