923697 - [B2G][Homescreen] There is not a character count limit on app names when users try to remove them

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Description:
There is not a character cap on collection names. Long collection names are not truncated under the collection icon and will be cutoff. Also, these long collection names cause strange scrolling issues on the "remove screen" and the long collection name will appear when moving around the collection on the homescreen.

Repro Steps:
1)  Updated Buri Build ID: 20131004040203
2)  Long press on an empty part of the homescreen.
3)  Tap on "Add Collection".
4)  Tap on "Custom".
5)  Tap inside the text box and enter in 200 characters.
6)  Tap "OK" and then observe the collection name under the icon created.
7)  Long press on the created collection and move the icon around the screen.
8)  Long press on the collection icon and tap the "X" button.
9)  On the "Remove" page, scroll the page to the right and then up and down.

Actual:
There is not a character count limit on collection names which causes issues.

Expected:
There is a character count limit on collection names.

Environmental Variables
Device: Buri v 1.3.0 Mozilla RIL
Build ID: 20131004040203
Gecko: http://hg.mozilla.org/mozilla-central/rev/8f08240128c8
Gaia: 1ac6749e36424124493a1b4c7534f298789bdffd
Platform Version: 27.0a1
RIL Version: 01.02.00.019.056 

Notes:
Repro frequency: 100%
See attached: video clip

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

The video has been posted on Youtube:

http://youtu.be/09yiOGCzG5s

Comment 2

[Jason Smith [:jsmith]]

(In reply to ktucker from comment #1)
> The video has been posted on Youtube:
> 
> http://youtu.be/09yiOGCzG5s

The youtube video here isn't viewable. This also needs a screenshot.

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

New URL for the Youtube video:

http://www.youtube.com/watch?v=pN3Vh9F0a18

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: Removing a collection with a long title

Comment 5

[Jason Smith [:jsmith]]

Okay. Sounds like a valid bug, but not a blocking issue.

Comment 6

[Ran Ben Aharon [:ranbena] EverythingMe]

Cristian, should this limit be set in Icon.setName?

Comment 7

[Cristian Rodriguez (:crdlc)]

Hi all, the name will be truncated in the UI, it makes sense

Comment 8

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: wrong UI
[Testing completed]: yes
[Risk to taking this patch] (and alternatives if risky): null
[String changes made]:

Comment 9

[Cristian Rodriguez (:crdlc)]

Attachment: Truncated titles.png

Results of the patch

Comment 10

[Ran Ben Aharon [:ranbena] EverythingMe]

Cristian, this works well for very long words. But what about a sequence of words? It'll make for a really high title and message in the dialog.

Comment 11

[Cristian Rodriguez (:crdlc)]

Attachment: Implemented Ran's suggestion

Comment 12

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 814041 [details]
Patch v1

Cool. Works great.

Comment 13

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/e907d0d84b86c54b7308ea228cfb785030755f4f

Comment 14

[Preeti Raghunath(:Preeti)]

Cristian,

What's the case for putting this in 1.2?

Is this a broken new e.me feature? Not sure why we would need to take it in 1.2

Comment 15

[Cristian Rodriguez (:crdlc)]

Hi,

   Honestly this bug can be reproducible in two scenarios:

1) New feature about adding a new collection (users can write long names)
2) Install a new app from marketplace with a very long name and trying to uninstall it

   The first case is not reproducible on v1.2 because the new feature won't be available. But the second, being a corner case, could appear on v1.2.

   I've change the bug title to describe the issue correctly

Thanks

Comment 16

[Preeti Raghunath(:Preeti)]

Comment on attachment 814041 [details]
Patch v1

wrong URL is misleading to the user. Hence 1.2+

Comment 17

[Jason Smith [:jsmith]]

Comment on attachment 814041 [details]
Patch v1

Actually, this isn't needed on 1.2 anymore. The e.me feature set was removed from 1.2, so we don't need this uplifted anymore.