923721 - [B2G][Everything.me] Low performance when a large collection app list re-organizes after removing an app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect, P1)

Description

[Matthew Vaughan]

Attachment: Video of low performance after removing an app from a collection with a lot of apps.

Description:
When deleting/removing an app from a collection that has a lot of apps already, the performance decreases significantly while the collection app list re-organizes. While the list re-organizes, the user will just see the small red edit buttons for each app but no app icons for a good 10 seconds.

Repro Steps:
1) Update Buri to Build ID: 20131004040203
2) Tap and enter a collection
3) Using long tap and the "Add to top of collection" button, add every app to the top of the collection that appears in the list
4) Long tap on an app and remove it

Actual:
Re-organization performance is decreased significantly; takes roughly 10 seconds to show any icons.

Expected:
App icons reappear within a second or two.

Environmental Variables
Device: Buri
Build ID: 20131004040203
Gecko: http://hg.mozilla.org/mozilla-central/rev/8f08240128c8
Gaia: 1ac6749e36424124493a1b4c7534f298789bdffd
Platform Version: 27.0a1

Notes:
Repro frequency: 100%
See attachment: CollectionPopPerf.mp4
Workaround: Don't add too many apps to the top of a collection.

Comment 1

[Jason Smith [:jsmith]]

10 seconds is way too long for a user - they'll likely get extremely annoyed with the phone if this happens.

Comment 2

[Amir Nissim (:amirn)]

Attachment: redirect to PR 12708.html

Comment 3

[Cristian Rodriguez (:crdlc)]

Comment on attachment 814075 [details]
redirect to PR 12708.html

Good work! it is streamly faster ;)

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

Comment on attachment 814075 [details]
redirect to PR 12708.html

Excellent fix.

Comment 5

[Amir Nissim (:amirn)]

landed in master
https://github.com/mozilla-b2g/gaia/commit/e89eb6fd0b7494abd5bdb330b527a9a2b764018c

Comment 6

[Jason Smith [:jsmith]]

Per a recent release drivers discussion, we need to hold off on uplifting this to 1.2 until we confirm a path forward post the planned e.me 1.2 status meeting tomorrow.

Comment 7

[Jason Smith [:jsmith]]

Clearing nom - we're no longer taking e.me 1.2 feature changes to 1.2.