Closed Bug 923721 Opened 8 years ago Closed 8 years ago

[B2G][Everything.me] Low performance when a large collection app list re-organizes after removing an app

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED
1.2 C3(Oct25)

People

(Reporter: mvaughan, Assigned: amirn)

References

Details

(Keywords: perf, Whiteboard: [c=effect p= s= u=] [e.me 1.2 test run])

Attachments

(2 files)

Description:
When deleting/removing an app from a collection that has a lot of apps already, the performance decreases significantly while the collection app list re-organizes. While the list re-organizes, the user will just see the small red edit buttons for each app but no app icons for a good 10 seconds.

Repro Steps:
1) Update Buri to Build ID: 20131004040203
2) Tap and enter a collection
3) Using long tap and the "Add to top of collection" button, add every app to the top of the collection that appears in the list
4) Long tap on an app and remove it

Actual:
Re-organization performance is decreased significantly; takes roughly 10 seconds to show any icons.

Expected:
App icons reappear within a second or two.

Environmental Variables
Device: Buri
Build ID: 20131004040203
Gecko: http://hg.mozilla.org/mozilla-central/rev/8f08240128c8
Gaia: 1ac6749e36424124493a1b4c7534f298789bdffd
Platform Version: 27.0a1

Notes:
Repro frequency: 100%
See attachment: CollectionPopPerf.mp4
Workaround: Don't add too many apps to the top of a collection.
Blocks: 1.3-e.me
10 seconds is way too long for a user - they'll likely get extremely annoyed with the phone if this happens.
blocking-b2g: --- → koi?
Keywords: perf
Assignee: nobody → amirn
Status: NEW → ASSIGNED
Attachment #814075 - Flags: review?(ran)
Attachment #814075 - Flags: review?(evyatar)
Attachment #814075 - Flags: review?(crdlc)
Attachment #814075 - Flags: review?(evyatar) → review+
Comment on attachment 814075 [details]
redirect to PR 12708.html

Good work! it is streamly faster ;)
Attachment #814075 - Flags: review?(crdlc) → review+
Comment on attachment 814075 [details]
redirect to PR 12708.html

Excellent fix.
Attachment #814075 - Flags: review?(ran) → review+
landed in master
https://github.com/mozilla-b2g/gaia/commit/e89eb6fd0b7494abd5bdb330b527a9a2b764018c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
blocking-b2g: koi? → koi+
Priority: -- → P1
Whiteboard: [e.me 1.2 test run] → [e.me 1.2 test run] [c=effect p= s=2013.10.18 u=1.2]
Whiteboard: [e.me 1.2 test run] [c=effect p= s=2013.10.18 u=1.2] → [e.me 1.2 test run] [c=effect p= s=2013.10.18 u=1.2][NO_UPLIFT]
Per a recent release drivers discussion, we need to hold off on uplifting this to 1.2 until we confirm a path forward post the planned e.me 1.2 status meeting tomorrow.
Clearing nom - we're no longer taking e.me 1.2 feature changes to 1.2.
blocking-b2g: koi+ → ---
Whiteboard: [e.me 1.2 test run] [c=effect p= s=2013.10.18 u=1.2][NO_UPLIFT] → [e.me 1.2 test run] [c=effect p= s=2013.10.18 u=1.2]
Whiteboard: [e.me 1.2 test run] [c=effect p= s=2013.10.18 u=1.2] → [e.me 1.2 test run] [c=effect p= s=2013.10.18 u=]
Target Milestone: --- → 1.2 C3(Oct25)
Whiteboard: [e.me 1.2 test run] [c=effect p= s=2013.10.18 u=] → [c=effect p= s= u=] [e.me 1.2 test run]
You need to log in before you can comment on or make changes to this bug.