Change - Download button should be hidden when there is no download in progress

VERIFIED FIXED in Firefox 27

Status

Firefox for Metro
Downloads
P2
normal
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Tracking

Trunk
Firefox 27
All
Windows 8.1
Dependency tree / graph
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: feature=change c=tbd u=tbd p=1)

Attachments

(3 attachments)

(Assignee)

Description

4 years ago
Created attachment 813874 [details] [diff] [review]
part 1: split up circularprogress CSS

shorlander requested (in person at the summit) that the download button in the navbar should be visible only when there is a download in progress.

The first patch on this bug just moves some code around to separate generic "circular progress" styles from specific download button styles.
Attachment #813874 - Flags: review?(msamuel)

Updated

4 years ago
Blocks: 915232
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: feature=change p=1 → feature=change c=tbd u=tbd p=1
(Assignee)

Comment 1

4 years ago
Created attachment 813875 [details] [diff] [review]
part 2: show download button only during download progress

This hides the download button when there is no download in progress.

Note: Since the download button is no longer in the navbar at "dl-request" time, it no longer makes sense to show the navbar then; instead we can show it when the download actually starts and the button appears.
Attachment #813875 - Flags: review?(msamuel)
(Assignee)

Comment 2

4 years ago
Created attachment 813921 [details] [diff] [review]
part 3: Make the download-complete notification toggleable

Also per shorlander's request, when I demoed parts 1 and 2 to him.  I know I resisted this previously, but trying it both ways, I agree that this improves the UX.

With this patch, we don't hide the download button until the user has chosen an action from the download-complete infobar.
Attachment #813921 - Flags: review?(msamuel)

Updated

4 years ago
Attachment #813874 - Flags: review?(msamuel) → review+
Comment on attachment 813875 [details] [diff] [review]
part 2: show download button only during download progress

Review of attachment 813875 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

This patch reminded me that someone at the summit while demo-ing mentioned that it's odd that the home page has some empty space on the right next to the urlbar where the toolbar buttons show up in a new tab. Do we or should we have a plan for a different UX for this?

::: browser/metro/base/content/downloads.js
@@ -92,5 @@
>            break;
>        }
>      }
>      if (this.manager.activeDownloadCount) {
> -      Services.obs.notifyObservers(null, "dl-request", "");

I believe we have another call like this in HelperAppDialog.js that we can get rid of.
Attachment #813875 - Flags: review?(msamuel) → review+
Comment on attachment 813921 [details] [diff] [review]
part 3: Make the download-complete notification toggleable

Review of attachment 813921 [details] [diff] [review]:
-----------------------------------------------------------------

Looks awesome! I like this approach :)
Attachment #813921 - Flags: review?(msamuel) → review+
https://hg.mozilla.org/mozilla-central/rev/7c65c5d7ad68
https://hg.mozilla.org/mozilla-central/rev/b417845bc606
https://hg.mozilla.org/mozilla-central/rev/3740ef3fb8a1
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0
Mozilla/5.0 (Windows NT 6.2; rv:27.0) Gecko/20100101 Firefox/27.0

Verified on the latest nightly (Build ID: 20131016030202)

If no download is started, the downloads button is not visible.
Could not completely verify this due to bug 927729, the circle won't disappear after the download is completed.
(Assignee)

Updated

4 years ago
Depends on: 927729
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0
Mozilla/5.0 (Windows NT 6.2; rv:27.0) Gecko/20100101 Firefox/27.0

Verified as fixed on latest Nightly (build ID: 20131028030205).

When a download is completed and the user selects "run" or "show in folder", the download button is not shown anymore. Also, the button is hidden when if user will cancel the download.
Status: RESOLVED → VERIFIED
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.