Create a shared library that allows to deal with FB Data in a DataStore

RESOLVED FIXED in 1.3 Sprint 4 - 11/8

Status

Firefox OS
Gaia::Contacts
P2
major
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jose Manuel Cantera, Assigned: Jose Manuel Cantera)

Tracking

unspecified
1.3 Sprint 4 - 11/8
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:-)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The shared library will be a refactoring of 

fb_contact.js, fb_contact_utils.js and other auxiliary .js files that will have to be revamped.
(Assignee)

Updated

5 years ago
blocking-b2g: --- → 1.3?
Depends on: 918827

Updated

5 years ago
Blocks: 918827
No longer depends on: 918827

Updated

5 years ago
Target Milestone: --- → 1.3 Sprint 4 - 11/8
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 824730 [details]
13236.html
Attachment #824730 - Flags: review?(crdlc)
triage: this is targeted for 1.3. would not block 1.3. please land it in master directly when ready
blocking-b2g: 1.3? → -
Comment on attachment 824730 [details]
13236.html

Please ask again for review when the comments will be addressed, great work my mate
Attachment #824730 - Flags: review?(crdlc)
(Assignee)

Comment 4

5 years ago
Comment on attachment 824730 [details]
13236.html

Hi Cristian,

All your comments addressed. Please could you re-review?

thanks
Attachment #824730 - Flags: review?(crdlc)
Comment on attachment 824730 [details]
13236.html

I have some comments on github to address if you consider that they are needed
Attachment #824730 - Flags: review?(crdlc) → review+
(Assignee)

Comment 6

5 years ago
last :crdlc comments addressed and merged!

https://github.com/mozilla-b2g/gaia/commit/333bd236accc1f73b631551232c32aeec3306ec9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
This might have caused bug 936494, but I'm not 100% sure.
Depends on: 936494
You need to log in before you can comment on or make changes to this bug.