Closed
Bug 924132
Opened 11 years ago
Closed 11 years ago
Create a shared library that allows to deal with FB Data in a DataStore
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)
Tracking
(blocking-b2g:-)
People
(Reporter: jmcf, Assigned: jmcf)
References
Details
Attachments
(1 file)
The shared library will be a refactoring of fb_contact.js, fb_contact_utils.js and other auxiliary .js files that will have to be revamped.
Assignee | ||
Updated•11 years ago
|
blocking-b2g: --- → 1.3?
Depends on: move-fb-to-datastore
Updated•11 years ago
|
Blocks: move-fb-to-datastore
No longer depends on: move-fb-to-datastore
Updated•11 years ago
|
Target Milestone: --- → 1.3 Sprint 4 - 11/8
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #824730 -
Flags: review?(crdlc)
Comment 2•11 years ago
|
||
triage: this is targeted for 1.3. would not block 1.3. please land it in master directly when ready
blocking-b2g: 1.3? → -
Comment 3•11 years ago
|
||
Comment on attachment 824730 [details]
13236.html
Please ask again for review when the comments will be addressed, great work my mate
Attachment #824730 -
Flags: review?(crdlc)
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 824730 [details]
13236.html
Hi Cristian,
All your comments addressed. Please could you re-review?
thanks
Attachment #824730 -
Flags: review?(crdlc)
Comment 5•11 years ago
|
||
Comment on attachment 824730 [details]
13236.html
I have some comments on github to address if you consider that they are needed
Attachment #824730 -
Flags: review?(crdlc) → review+
Assignee | ||
Comment 6•11 years ago
|
||
last :crdlc comments addressed and merged! https://github.com/mozilla-b2g/gaia/commit/333bd236accc1f73b631551232c32aeec3306ec9
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 7•11 years ago
|
||
This might have caused bug 936494, but I'm not 100% sure.
Depends on: 936494
You need to log in
before you can comment on or make changes to this bug.
Description
•