Closed Bug 924132 Opened 12 years ago Closed 12 years ago

Create a shared library that allows to deal with FB Data in a DataStore

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:-)

Status:
RESOLVED FIXED
Milestone:
1.3 Sprint 4 - 11/8
Project Flags:
blocking-b2g -

People

(Reporter: jmcf, Assigned: jmcf)

References

Details

Attachments

(1 file)

13236.html
191 bytes, text/html
crdlc
: review+
Details
The shared library will be a refactoring of fb_contact.js, fb_contact_utils.js and other auxiliary .js files that will have to be revamped.
blocking-b2g: --- → 1.3?
Depends on: move-fb-to-datastore
Blocks: move-fb-to-datastore
No longer depends on: move-fb-to-datastore
Target Milestone: --- → 1.3 Sprint 4 - 11/8
Status: NEW → ASSIGNED
Attached file 13236.html —
Attachment #824730 - Flags: review?(crdlc)
triage: this is targeted for 1.3. would not block 1.3. please land it in master directly when ready
blocking-b2g: 1.3? → -
Comment on attachment 824730 [details] 13236.html Please ask again for review when the comments will be addressed, great work my mate
Attachment #824730 - Flags: review?(crdlc)
Comment on attachment 824730 [details] 13236.html Hi Cristian, All your comments addressed. Please could you re-review? thanks
Attachment #824730 - Flags: review?(crdlc)
Comment on attachment 824730 [details] 13236.html I have some comments on github to address if you consider that they are needed
Attachment #824730 - Flags: review?(crdlc) → review+
last :crdlc comments addressed and merged! https://github.com/mozilla-b2g/gaia/commit/333bd236accc1f73b631551232c32aeec3306ec9
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
This might have caused bug 936494, but I'm not 100% sure.
Depends on: 936494
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: