936494 - String not showing correctly after export to SD card

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Zac C (:zac)]

Attachment: 2013-06-01-06-15-27.png

Device Hamachi
Gecko  http://hg.mozilla.org/mozilla-central/rev/70f21fad60a4
Gaia  f7b408fe7e40a6e783e3f29c5cea5ec5ba5349ae
BuildID 20131108040203
Version 28.0a1



1. Load Contacts app
2. Create a contact
3. Open settings menu
4. Tap Export, export to SD card
5. Select the contact
6. Tap export
7. Note the string in the notification toaster (bottom of screen)

Also see screenshot.

Comment 1

[Jason Smith [:jsmith]]

Does this reproduce on 1.2?

Comment 2

[Jason Smith [:jsmith]]

The only commit that might have caused this regression is bug 924132, although I'm not 100% sure on this one.

Comment 3

[Natalya Kot [:nkot]]

(In reply to Jason Smith [:jsmith] from comment #1)
> Does this reproduce on 1.2?

It doesn't.

Tried exporting one contact and multiple (12) contacts -> correct message is displayed 

Buri 1.2
BuildID: 20131108004004
Gaia: 4cf40fb30c7b8380ea83ed0d4efe043b8b81737f
Gecko: a886c641a306
Version: 26.0

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to PR 13694

Comment 6

[Jason Smith [:jsmith]]

Francisco - Can you land this?

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Sorry, was on PTO and totally forgot about this.

Landing this in 3,2,1 ...

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Landed:


https://github.com/mozilla-b2g/gaia/commit/64bb460bea0fc9d81e54fdb27690e5984c4cf13c

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

already in master. clear flag

Comment 10

[Jason Smith [:jsmith]]

(In reply to Joe Cheng [:jcheng] from comment #9)
> already in master. clear flag

If this is a legitimate blocking regression, it should block. Setting 1.3+.

Comment 11

[Zac C (:zac)]

Verified fixed!