Closed
Bug 924201
Opened 11 years ago
Closed 11 years ago
urlbar-container should not have separators between its buttons
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: mconley, Assigned: mconley)
References
(Depends on 1 open bug)
Details
(Keywords: perf, Whiteboard: [Australis:P1][Australis:M9])
Attachments
(1 file)
|
1.01 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
Bug 859776 added separators before dropmarkers and between consecutive toolbarbuttons within a toolbaritem (like the zoom / edit controls). This is fine, except that it adds a separator between the back and forward buttons in the urlbar-container, which is superfluous.
|
Assignee | |
Comment 1•11 years ago
|
||
Special-case the urlbar-container.
|
|
Assignee | |
Updated•11 years ago
|
Attachment #814203 -
Flags: review?(gijskruitbosch+bugs)
|
|
Assignee | |
Comment 2•11 years ago
|
||
I a word in the summary.
Summary: urlbar-container should have separators between its buttons → urlbar-container should not have separators between its buttons
|
||
Comment 3•11 years ago
|
||
Comment on attachment 814203 [details] [diff] [review] Patch v1 Review of attachment 814203 [details] [diff] [review]: ----------------------------------------------------------------- r=me for now, but let's have a followup about why this is navbar specific, and if it's that specific, whether we should change it to be specific to certain buttons rather than excluding other stuff, or make it more general and override the urlbar-container the way add-ons would have to override their own split buttons.
Attachment #814203 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Thanks! Landed on UX as https://hg.mozilla.org/projects/ux/rev/b6b9e744baeb
Status: NEW → ASSIGNED
Whiteboard: [Australis:P1][Australis:M9][fixed-in-ux]
|
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b6b9e744baeb
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P1][Australis:M9][fixed-in-ux] → [Australis:P1][Australis:M9]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•