924202 - Add the separator to combined buttons outside of the #nav-bar

Status: NEW

(Firefox :: Theme, defect)

Description

[:Gijs (he/him)]

So in bug 924201 mconley noted that the urlbar-container now has a separator drawn where it shouldn't, because it's being matched by these rules. We'll now explicitly exclude the urlbar-container's back/fwd button, but it made me wonder about this rule:

a) why only #nav-bar? Why not all toolbars?
b) if there's some reason not to generalize, maybe we should instead just restrict it to the buttons in question, or a particular opt-in class. That'll be easier for add-ons, too, and it'll help with stuff like bug 916953.

Mike and I weren't really decided, I think (perhaps in part due to summit-induced ineptness towards making decisions). Jared, got an opinion on this one? :-)

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to :Gijs Kruitbosch from comment #0)
> a) why only #nav-bar? Why not all toolbars?

Because only the #nav-bar has the "Australis"-styled buttons so far. We'll need to fix the bugs blocking bug 767319 before we can place the separators elsewhere.

> b) if there's some reason not to generalize, maybe we should instead just
> restrict it to the buttons in question, or a particular opt-in class.
> That'll be easier for add-ons, too, and it'll help with stuff like bug
> 916953.

This was fixed in bug 924933.