Closed
Bug 924318
Opened 12 years ago
Closed 12 years ago
Clean up ecma_6/Generators iterator tests
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: wingo, Assigned: wingo)
References
Details
Attachments
(2 files, 2 obsolete files)
|
23.32 KB,
patch
|
wingo
:
review+
|
Details | Diff | Splinter Review |
|
46.03 KB,
patch
|
wingo
:
review+
|
Details | Diff | Splinter Review |
tests/ecma_6/Generators includes a version of assertIteratorResult that has the expected values first, unlike the one in jit-tests/lib/iteration.js. This patch will change the jstests to match the jittests, and to match the general (ACTUAL, EXPECTED) argument order.
| Assignee | ||
Comment 1•12 years ago
|
||
| Assignee | ||
Updated•12 years ago
|
Assignee: nobody → wingo
| Assignee | ||
Updated•12 years ago
|
Attachment #814310 -
Flags: review?(jwalden+bmo)
| Assignee | ||
Comment 2•12 years ago
|
||
As suggested by Waldo over IRC, this patch adds assertIteratorNext / assertIteratorDone helpers.
Attachment #814323 -
Flags: review?(jwalden+bmo)
Updated•12 years ago
|
Attachment #814310 -
Flags: review?(jwalden+bmo) → review+
Updated•12 years ago
|
Attachment #814323 -
Flags: review?(jwalden+bmo) → review+
| Assignee | ||
Comment 3•12 years ago
|
||
| Assignee | ||
Updated•12 years ago
|
Attachment #814310 -
Attachment is obsolete: true
| Assignee | ||
Comment 4•12 years ago
|
||
| Assignee | ||
Updated•12 years ago
|
Attachment #814323 -
Attachment is obsolete: true
| Assignee | ||
Updated•12 years ago
|
Attachment #818387 -
Attachment description: Clean up ecma_6/Generators iterator tests → Clean up ecma_6/Generators iterator tests r=jwalden
Attachment #818387 -
Flags: review+
| Assignee | ||
Updated•12 years ago
|
Attachment #818388 -
Attachment description: More iterator test cleanups → More iterator test cleanups r=jwalden
Attachment #818388 -
Flags: review+
Comment 6•12 years ago
|
||
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4d45af314d05
https://hg.mozilla.org/mozilla-central/rev/68149d83be3a
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•