Closed Bug 924318 Opened 6 years ago Closed 6 years ago

Clean up ecma_6/Generators iterator tests

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: wingo, Assigned: wingo)

References

Details

Attachments

(2 files, 2 obsolete files)

tests/ecma_6/Generators includes a version of assertIteratorResult that has the expected values first, unlike the one in jit-tests/lib/iteration.js.  This patch will change the jstests to match the jittests, and to match the general (ACTUAL, EXPECTED) argument order.
Assignee: nobody → wingo
Attachment #814310 - Flags: review?(jwalden+bmo)
Attached patch More iterator test cleanups (obsolete) — Splinter Review
As suggested by Waldo over IRC, this patch adds assertIteratorNext / assertIteratorDone helpers.
Attachment #814323 - Flags: review?(jwalden+bmo)
Attachment #814310 - Flags: review?(jwalden+bmo) → review+
Attachment #814323 - Flags: review?(jwalden+bmo) → review+
Attachment #814310 - Attachment is obsolete: true
Attachment #814323 - Attachment is obsolete: true
Attachment #818387 - Attachment description: Clean up ecma_6/Generators iterator tests → Clean up ecma_6/Generators iterator tests r=jwalden
Attachment #818387 - Flags: review+
Attachment #818388 - Attachment description: More iterator test cleanups → More iterator test cleanups r=jwalden
Attachment #818388 - Flags: review+
Thanks for the review!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4d45af314d05
https://hg.mozilla.org/mozilla-central/rev/68149d83be3a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Duplicate of this bug: 924317
You need to log in before you can comment on or make changes to this bug.