tests/ecma_6/Generators includes a version of assertIteratorResult that has the expected values first, unlike the one in jit-tests/lib/iteration.js. This patch will change the jstests to match the jittests, and to match the general (ACTUAL, EXPECTED) argument order.
Attachment #814310 - Flags: review?(jwalden+bmo)
Created attachment 814323 [details] [diff] [review] More iterator test cleanups As suggested by Waldo over IRC, this patch adds assertIteratorNext / assertIteratorDone helpers.
Attachment #814323 - Flags: review?(jwalden+bmo)
Attachment #814310 - Flags: review?(jwalden+bmo) → review+
Attachment #814323 - Flags: review?(jwalden+bmo) → review+
Created attachment 818387 [details] [diff] [review] Clean up ecma_6/Generators iterator tests r=jwalden
Attachment #814310 - Attachment is obsolete: true
Attachment #814323 - Attachment is obsolete: true
Thanks for the review!
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/4d45af314d05 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/68149d83be3a
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: x86_64 → All
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.