924549 - Add a new kind of manifest for webapprt chrome tests and convert webapprt mochitests to use manifests

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect)

Description

[Marco Castelluccio [:marco]]

Add MOCHITEST_WEBAPPRT_CHROME_MANIFESTS to specify webapprt chrome tests and convert all the webapprt mochitests to use manifests.

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 814486 [details] [diff] [review]
Patch

Review of attachment 814486 [details] [diff] [review]:
-----------------------------------------------------------------

Should we name webapprt manifests "webapprt.ini" (or similar) by convention? Whatever the answer is, please update build/docs/test_manifests.rst with the used convention so things are explicitly documented.

Also, the _MOZBUILD_EXTERNAL_VARIABLES list at the top of rules.mk should be updated to include MOCHITEST_WEBAPPRT_CHROME_FILES. This will cause MOCHITEST_WEBAPPRT_CHROME_FILES defined in Makefile.in to result in a build error.

Comment 3

[Marco Castelluccio [:marco]]

Attachment: Patch

Carrying r+.
I've added the MOCHITEST_WEBAPPRT_CHROME_FILES variable to the deprecated variables list.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/18d00b699ad6

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/18d00b699ad6