92508 - two copies of nsIHelperAppLauncherDialog.idl in the tree.

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Judson Valeski]

We have two copies of the same interface in the tree, causes confusion and opens
the door for discrepancies.

Comment 1

[Judson Valeski]

Attachment: patch to remove the extraneous file.

Comment 2

[Judson Valeski]

this patch cleans up some comments, and rips out the .idl file from the
xpfe/components/ucth directory.

seeking review.

Comment 3

[Conrad Carlen (not reading bugmail)]

I hope anything that's using promptForSaveToFile() is getting the right version
in the includes because the decl of that method is different between the two
copies of the file. Assuming you've done a full build and verified that, r=ccarlen

Comment 4

[Judson Valeski]

-> law. I won't get to this.

Comment 5

[Bill Law]

->mozilla0.9.7

Comment 6

[Bill Law]

Attachment: patch to remove xpfe/components/ucth in its entirety

This patch moves the download progress dialog .xul/.js files to their rightful
home in embedding/components/ui/progressDlg.  That task (by itself) helps to
fix bug 73106.

The files are renamed, and added to the jar.mn in embedding/components/ui.  The
corresponding ucth files are removed from the jar.mn in xpfe/components.

The only other changes are tweaks to the code in nsHelperAppDlg.js and
nsProgressDlg.xul to account for the change in name from helperAppDldProgress.*
to nsProgressDlg.*.

With this change applied, we can then nuke xpfe/components/ucth completely.

Please review.

Comment 7

[Conrad Carlen (not reading bugmail)]

Comment on attachment 59648 [details] [diff] [review]
patch to remove xpfe/components/ucth in its entirety

Did you check whether or not this effects chrome building in embedding/config?
Assuming no harm there, r=ccarlen.

Comment 8

[Bill Law]

These files/directories aren't mentioned anywhere in embedding/config, so I
think there's no problem there.  Thanks for the review.

Comment 9

[Scott MacGregor]

Comment on attachment 59648 [details] [diff] [review]
patch to remove xpfe/components/ucth in its entirety

sr=mscott

Comment 10

[Bill Law]

There are still some random references to the "ucth" directory in various places
(e.g., allmakefiles.sh, some Mac project files).  I want to clean those up
before nuking the entire directory so I'm pushing this bug off till next milestone.

Comment 11

[Bill Law]

All these download related items are moving out; delayed due to overhaul of 
downloading and many regressions in this area.

Comment 12

[Bill Law]

Spam: Setting target milestone for all these to Future.

Please note that most, if not all, will be fixed in the course of the work I'm 
doing for bug 27609.  That fact is noted in the "depends on" field for each of 
these bugs (I think; go ahead and remedy that if you like).

I just don't have time to deal with the wrath that comes with having too many 
bugs.

Comment 13

[Boris Zbarsky [:bzbarsky]]

This gut fixed by bug 156723 -- xpfe/components/ucth is no longer.

Comment 14

[David Epstein]

verified.