Closed Bug 92508 Opened 25 years ago Closed 23 years ago

two copies of nsIHelperAppLauncherDialog.idl in the tree.

Categories

(Core Graveyard :: Embedding: APIs, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Future

People

(Reporter: jud, Assigned: law)

References

Details

Attachments

(1 file, 1 obsolete file)

We have two copies of the same interface in the tree, causes confusion and opens the door for discrepancies.
this patch cleans up some comments, and rips out the .idl file from the xpfe/components/ucth directory. seeking review.
I hope anything that's using promptForSaveToFile() is getting the right version in the includes because the decl of that method is different between the two copies of the file. Assuming you've done a full build and verified that, r=ccarlen
-> law. I won't get to this.
Assignee: valeski → law
QA Contact: mdunn → depstein
->mozilla0.9.7
Target Milestone: --- → mozilla0.9.7
This patch moves the download progress dialog .xul/.js files to their rightful home in embedding/components/ui/progressDlg. That task (by itself) helps to fix bug 73106. The files are renamed, and added to the jar.mn in embedding/components/ui. The corresponding ucth files are removed from the jar.mn in xpfe/components. The only other changes are tweaks to the code in nsHelperAppDlg.js and nsProgressDlg.xul to account for the change in name from helperAppDldProgress.* to nsProgressDlg.*. With this change applied, we can then nuke xpfe/components/ucth completely. Please review.
Attachment #43742 - Attachment is obsolete: true
Comment on attachment 59648 [details] [diff] [review] patch to remove xpfe/components/ucth in its entirety Did you check whether or not this effects chrome building in embedding/config? Assuming no harm there, r=ccarlen.
Attachment #59648 - Flags: review+
These files/directories aren't mentioned anywhere in embedding/config, so I think there's no problem there. Thanks for the review.
Whiteboard: needs super-review (mscott)
Comment on attachment 59648 [details] [diff] [review] patch to remove xpfe/components/ucth in its entirety sr=mscott
Attachment #59648 - Flags: superreview+
Whiteboard: needs super-review (mscott)
There are still some random references to the "ucth" directory in various places (e.g., allmakefiles.sh, some Mac project files). I want to clean those up before nuking the entire directory so I'm pushing this bug off till next milestone.
Target Milestone: mozilla0.9.7 → mozilla0.9.8
All these download related items are moving out; delayed due to overhaul of downloading and many regressions in this area.
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Status: NEW → ASSIGNED
Depends on: 27609
Target Milestone: mozilla0.9.9 → ---
Target Milestone: --- → mozilla1.0
Spam: Setting target milestone for all these to Future. Please note that most, if not all, will be fixed in the course of the work I'm doing for bug 27609. That fact is noted in the "depends on" field for each of these bugs (I think; go ahead and remedy that if you like). I just don't have time to deal with the wrath that comes with having too many bugs.
Target Milestone: mozilla1.0 → Future
This gut fixed by bug 156723 -- xpfe/components/ucth is no longer.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
verified.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: