925108 - RTL support for tab tray

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect, P1)

Description

[Lauren]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.69 Safari/537.36

Steps to reproduce:

RTL support for the tab tray. Blocks bug 702845

Comment 1

[Lauren]

Attachment: work in progress

Comment 2

[Lauren]

Attachment: work in progress

this patch mirrors the tab tray for mobile in rtl, but keeps the tab tray on the left for tablet landscape in rtl.

Comment 3

[Niv Yahel]

Attachment: TabTray.patch

I fixed the icon alignment to your patch. :-)

Comment 4

[Lauren]

Attachment: xlarge bug

Comment 5

[Lauren]

Attachment: xlarge bug - portrait

Comment 6

[Lauren]

Attachment: xlarge bug - landscape

Comment 7

[Itiel]

Checking on a mobile phone (NOT tablet), it seems perfectly RTL'd in latest Nightly builds.
Other users may need to verify this is fixed also on tablets.

Comment 8

[Rachelle Yang [:ryang][[e-mail]]]

Hi Ioana and Sorina ,

would you please help us verify this RTL support on Fennec after Bug 1319302 is already resolved fixed ? 
Could you help us create the complete RTL test cases  and its corresponding wiki test page for tracking ?
Or did you already have the wiki page for RTL test plan on Fennec ?

Thank you very much !

Comment 9

[Reza Habibi (rehb)]

Attachment: Mobile-landscape(fixed).png

Comment 10

[Reza Habibi (rehb)]

Attachment: Tablet-fa(fixed).png

Comment 11

[Reza Habibi (rehb)]

(In reply to Rachelle Yang [:ryang][[e-mail]] from comment #8)
> Hi Ioana and Sorina ,
> 
> would you please help us verify this RTL support on Fennec after Bug 1319302
> is already resolved fixed ? 
> Could you help us create the complete RTL test cases  and its corresponding
> wiki test page for tracking ?
> Or did you already have the wiki page for RTL test plan on Fennec ?
> 
> Thank you very much !

Hi,
It seems fixed on the Mobile and Tablet in both rotations.

Bests,
Reza.

Comment 12

[Itiel]

(In reply to Reza (rehb) from comment #11)
> (In reply to Rachelle Yang [:ryang][[e-mail]] from comment #8)
> > Hi Ioana and Sorina ,
> > 
> > would you please help us verify this RTL support on Fennec after Bug 1319302
> > is already resolved fixed ? 
> > Could you help us create the complete RTL test cases  and its corresponding
> > wiki test page for tracking ?
> > Or did you already have the wiki page for RTL test plan on Fennec ?
> > 
> > Thank you very much !
> 
> Hi,
> It seems fixed on the Mobile and Tablet in both rotations.
> 
> Bests,
> Reza.

According to your screenshots, it seems it is NOT fixed?

Comment 13

[Reza Habibi (rehb)]

(In reply to ItielMaN from comment #12)
> (In reply to Reza (rehb) from comment #11)
> > (In reply to Rachelle Yang [:ryang][[e-mail]] from comment #8)
> > > Hi Ioana and Sorina ,
> > > 
> > > would you please help us verify this RTL support on Fennec after Bug 1319302
> > > is already resolved fixed ? 
> > > Could you help us create the complete RTL test cases  and its corresponding
> > > wiki test page for tracking ?
> > > Or did you already have the wiki page for RTL test plan on Fennec ?
> > > 
> > > Thank you very much !
> > 
> > Hi,
> > It seems fixed on the Mobile and Tablet in both rotations.
> > 
> > Bests,
> > Reza.
> 
> According to your screenshots, it seems it is NOT fixed?

1- Text and close icon fixed.
2- Border overflow[1]==>fixed [2].
3- The only problem is to arrange of tab[3] that belongs to other Bug.



1- https://bug925108.bmoattachments.org/attachment.cgi?id=831048
2- https://bugzilla.mozilla.org/attachment.cgi?id=8816043
3- https://bug925108.bmoattachments.org/attachment.cgi?id=8816044

Comment 14

[Itiel]

(In reply to Reza (rehb) from comment #13)
> 1- Text and close icon fixed.
> 2- Border overflow[1]==>fixed [2].
> 3- The only problem is to arrange of tab[3] that belongs to other Bug.
> 
> 
> 
> 1- https://bug925108.bmoattachments.org/attachment.cgi?id=831048
> 2- https://bugzilla.mozilla.org/attachment.cgi?id=8816043
> 3- https://bug925108.bmoattachments.org/attachment.cgi?id=8816044

According to your screenshots it seems either Persian builds aren't RTL yet, or you have an outdated Nightly build.
I can't see any RTL in these images.

See attached screenshot with PERFECT RTL changes.

Comment 15

[Itiel]

Attachment: RTL'd tab tray

Comment 16

[Khaled Hosny]

Tested with Arabic looks as attachment 8816252 [details], which is what I’d expect.

Comment 17

[Itiel]

(In reply to Khaled Hosny from comment #16)
> Tested with Arabic looks as attachment 8816252 [details], which is what I’d
> expect.

Did you test it on a tablet device by any chance?

Comment 18

[Reza Habibi (rehb)]

(In reply to ItielMaN from comment #14)
> (In reply to Reza (rehb) from comment #13)
> > 1- Text and close icon fixed.
> > 2- Border overflow[1]==>fixed [2].
> > 3- The only problem is to arrange of tab[3] that belongs to other Bug.
> > 
> > 
> > 
> > 1- https://bug925108.bmoattachments.org/attachment.cgi?id=831048
> > 2- https://bugzilla.mozilla.org/attachment.cgi?id=8816043
> > 3- https://bug925108.bmoattachments.org/attachment.cgi?id=8816044
> 
> According to your screenshots it seems either Persian builds aren't RTL yet,
> or you have an outdated Nightly build.
> I can't see any RTL in these images.
> 
> See attached screenshot with PERFECT RTL changes.

I updated the Night build version and Yes, Persian builds that I installed aren't RTL yet in some parts.

Comment 19

[Khaled Hosny]

(In reply to ItielMaN from comment #17)
> (In reply to Khaled Hosny from comment #16)
> > Tested with Arabic looks as attachment 8816252 [details], which is what I’d
> > expect.
> 
> Did you test it on a tablet device by any chance?

Looks the same on tablet.

Comment 20

[Sorina Florean [:sflorean]]

Hi all,

Tested and verified RTL support for tab tray on latest Nightly (Arabic) and the results are here:
Phone:
- LG G4 (Android 5.1) - https://i.imgur.com/nRlMnwV.png
- Lenovo A536 (Android 4.4.2) - https://i.imgur.com/7ldVdlP.png
Tablet:
- Nexus 9 (Android 7.0) - https://i.imgur.com/N7DwvGQ.png
- Asus ZenPad 8 (Android 6.0.1) - https://i.imgur.com/SqsBghh.png.

Comment 21

[Itiel]

(In reply to Sorina Florean [:sorina] from comment #20)
> Hi all,
> 
> Tested and verified RTL support for tab tray on latest Nightly (Arabic) and
> the results are here:
> Phone:
> - LG G4 (Android 5.1) - https://i.imgur.com/nRlMnwV.png
> - Lenovo A536 (Android 4.4.2) - https://i.imgur.com/7ldVdlP.png
> Tablet:
> - Nexus 9 (Android 7.0) - https://i.imgur.com/N7DwvGQ.png
> - Asus ZenPad 8 (Android 6.0.1) - https://i.imgur.com/SqsBghh.png.

Thanks Sorina, but if accounting for your screenshot from bug 924699 (https://i.imgur.com/t6qFFGN.png), the opened tab there isn't RTL'd. It should be aligned to the right (though, I'm not sure if the New Tab button ("+") should also be aligned to the right).

Comment 22

[Reza Habibi (rehb)]

(In reply to ItielMaN from comment #21)
> (In reply to Sorina Florean [:sorina] from comment #20)
> > Hi all,
> > 
> > Tested and verified RTL support for tab tray on latest Nightly (Arabic) and
> > the results are here:
> > Phone:
> > - LG G4 (Android 5.1) - https://i.imgur.com/nRlMnwV.png
> > - Lenovo A536 (Android 4.4.2) - https://i.imgur.com/7ldVdlP.png
> > Tablet:
> > - Nexus 9 (Android 7.0) - https://i.imgur.com/N7DwvGQ.png
> > - Asus ZenPad 8 (Android 6.0.1) - https://i.imgur.com/SqsBghh.png.
> 
> Thanks Sorina, but if accounting for your screenshot from bug 924699
> (https://i.imgur.com/t6qFFGN.png), the opened tab there isn't RTL'd. It
> should be aligned to the right (though, I'm not sure if the New Tab button
> ("+") should also be aligned to the right).

‌Based on this Review [1] I think the New tab button from this screenshot[2]is RTL.

1 -https://bug702845.bmoattachments.org/attachment.cgi?id=8787324
2-https://i.imgur.com/t6qFFGN.png

Comment 23

[Itiel]

(In reply to Reza (rehb) from comment #22)
> ‌Based on this Review [1] I think the New tab button from this
> screenshot[2]is RTL.
> 
> 1 -https://bug702845.bmoattachments.org/attachment.cgi?id=8787324
> 2-https://i.imgur.com/t6qFFGN.png

Hmm, thanks for pointing this out. Didn't know how it looked on tablets with LTR builds.

Comment 24

[Max Liu [:maliu]]

This bug is fixed by Bug 1317466, replacing TwoWayView with RecyclerView.

Comment 25

[Itiel]

Sorina, can you please verify this is fixed on your Nexus 9 (Android 7.0) device? (see comment 21)
Thank you.

Comment 26

[Sorina Florean [:sflorean]]

Hi,

Tested with Nexus 9 (Android 7.0) on latest Nightly (2016-12-28) AR language. Here is the screenshots: https://i.imgur.com/voAuVXL.png.

Comment 27

[Itiel]

(In reply to Sorina Florean [:sorina] from comment #26)
> Hi,
> 
> Tested with Nexus 9 (Android 7.0) on latest Nightly (2016-12-28) AR
> language. Here is the screenshots: https://i.imgur.com/voAuVXL.png.

Thanks Sorina, looking good.
I don't see any other bugs with the tab tray, closing as RESOLVED FIXED.
Feel free to reopen if you think otherwise.

Comment 28

[Ioana Chiorean]

Per previous comments, I will set the bug as verified fixed.