925218 - -x-system-font should be set by the 'all' shorthand

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

Per bug 842329 comment 23.

Comment 1

[Cameron McCormack (:heycam)]

Attachment: patch

Comment 2

[Cameron McCormack (:heycam)]

https://tbpl.mozilla.org/?tree=Try&rev=5556b01f896b

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 815202 [details] [diff] [review]
patch

> // Callers may also define CSS_PROP_LIST_ONLY_COMPONENTS_OF_ALL_SHORTHAND
> // to exclude properties that are not considered to be components of the 'all'
>+// shorthand property.  Currently this excludes 'direction' and 'unicode-bidi',
>+// as required by the CSS Cascading and Inheritance specification, and any
>+// internal properties that are set indirectly by some other shorthand

set -> not set, I think.  Though maybe it's better to say internal properties that can't be changed using CSS syntax.

>+// that is not an internal property (i.e., the value of the internal property
>+// can be set by user style sheets).

drop the "user" in "user style sheets", since that makes it sounds like you're talking about the cascade level.



r=dbaron, and thanks for fixing

Comment 4

[Cameron McCormack (:heycam)]

I tweaked the wording further to be clearer, including an example.

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa11ee736eff

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/aa11ee736eff