Closed Bug 925218 Opened 6 years ago Closed 6 years ago

-x-system-font should be set by the 'all' shorthand

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

Blocks: 925193
Attached patch patchSplinter Review
Attachment #815202 - Flags: review?(dbaron)
Comment on attachment 815202 [details] [diff] [review]
patch

> // Callers may also define CSS_PROP_LIST_ONLY_COMPONENTS_OF_ALL_SHORTHAND
> // to exclude properties that are not considered to be components of the 'all'
>+// shorthand property.  Currently this excludes 'direction' and 'unicode-bidi',
>+// as required by the CSS Cascading and Inheritance specification, and any
>+// internal properties that are set indirectly by some other shorthand

set -> not set, I think.  Though maybe it's better to say internal properties that can't be changed using CSS syntax.

>+// that is not an internal property (i.e., the value of the internal property
>+// can be set by user style sheets).

drop the "user" in "user style sheets", since that makes it sounds like you're talking about the cascade level.



r=dbaron, and thanks for fixing
Attachment #815202 - Flags: review?(dbaron) → review+
I tweaked the wording further to be clearer, including an example.

https://hg.mozilla.org/integration/mozilla-inbound/rev/aa11ee736eff
https://hg.mozilla.org/mozilla-central/rev/aa11ee736eff
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.