Closed
Bug 925415
Opened 11 years ago
Closed 11 years ago
Remove dead tab opacity transition code from themes/osx/browser.css
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: mconley, Assigned: mconley)
References
Details
(Whiteboard: [Australis:P5][Australis:M9])
Attachments
(1 file)
|
821 bytes,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
A follow-up to bug 919541 - I didn't realize that the OS X theme overrides the tab animation rules in browser/base/content/browser.css, so it got missed in the original patch.
This should give us some tab-close wins on OS X.
|
||
Comment 1•11 years ago
|
||
Should be a no-op given bug 919947.
No longer blocks: australis-tabs-perf, australis-tart
Keywords: perf
Whiteboard: [Australis:P1][Australis:M?] → [Australis:P5][Australis:M?]
|
Assignee | |
Comment 2•11 years ago
|
||
Bubble: burst.
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #815890 -
Flags: review?(gijskruitbosch+bugs)
|
||
Comment 4•11 years ago
|
||
Comment on attachment 815890 [details] [diff] [review]
Patch v1
Review of attachment 815890 [details] [diff] [review]:
-----------------------------------------------------------------
Ship it.
Attachment #815890 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Assignee | |
Updated•11 years ago
|
Summary: Stop animating opacity of tabs when closing them → Remove dead tab opacity transition code from themes/osx/browser.css
|
|
Assignee | |
Comment 5•11 years ago
|
||
Thanks - landed on UX as https://hg.mozilla.org/projects/ux/rev/fefb4e96a892
Status: NEW → ASSIGNED
Whiteboard: [Australis:P5][Australis:M?] → [Australis:P5][Australis:M9][fixed-in-ux]
|
|
Assignee | |
Comment 6•11 years ago
|
||
Uh, this patch seems to have caused a pretty dramatic spike on the 10.6 TART results:
https://datazilla.mozilla.org/?start=1380884848&stop=1381510597&product=Firefox&repository=Firefox&os=mac&os_version=OS%20X%2010.6.8&test=tart&graph_search=fefb4e96a892&tr_id=3111542&graph=simple-open-DPI1.all.TART&compare_product=Firefox&compare_repository=UX&project=talos
Triggering some more to ensure this isn't just a fluke...
|
|
Assignee | |
Comment 7•11 years ago
|
||
Retriggers suggest this was a fluke. Stand down red alert.
|
|
||
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P5][Australis:M9][fixed-in-ux] → [Australis:P5][Australis:M9]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•