925538 - Synchronous file picker is broken

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Last fixup for file pickers, I implemented show() using some common code in PromptService.js. They're deprecated, but we should make them work.

Comment 1

[Wesley Johnston (:wesj)]

Attachment: Patch

I stole some code from PromptService that I shouldn't have.

Comment 2

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/8804ec54fbcb

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 815608 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 874689
User impact if declined: Trying to use the synchronous file picker api is busted. The API is deprecated, but add-ons may try to use it anyway. It works on desktop, so it creates more work for them to figure out why the api doesn't also work on mobile.
Testing completed (on m-c, etc.): Landed on mc today
Risk to taking this patch (and alternatives if risky): We could not fire these dom events for file pickers with little affect on the real world.
String or IDL/UUID changes made by this patch: None.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8804ec54fbcb

Comment 5

[Alex Keybl [:akeybl]]

I'm hoping kbrosnan can verify no new regressions to the file pickers prior to our final beta, in case we need to take another forward fix (or back this out).

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

Tested nightly and aurora with people.mozilla.org/~wjohnston/abouttests.xpi in aurora the synchronous file picker button does not work. In nightly it fires the same intent as the async one.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9d6d3d4f2727
https://hg.mozilla.org/releases/mozilla-beta/rev/eeea6cc5c54a