Closed
Bug 925619
Opened 11 years ago
Closed 11 years ago
Infinite loops in AudioBufferSourceNodeEngine::ProduceAudioBlock()
Categories
(Core :: Web Audio, defect)
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: karlt, Assigned: karlt)
References
Details
Attachments
(4 files)
|
486 bytes,
text/html
|
Details | |
|
496 bytes,
text/html
|
Details | |
|
4.54 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
|
1.24 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
This runs on the media stream graph thread(s), so symptoms are cpu use, lack of audio, and failure to shut down. 89478.5 is a little under 25 hours. When current time approaches this there a similar problems, but the 2 testcases I'll attach don't require waiting for 25 hours.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #815715 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #815716 -
Flags: review?(ehsan)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 815715 [details] [diff] [review]
truncate TrackTicks differences to uint32_t after limiting to WEBAUDIO_BLOCK_SIZE
Swapped some lengths in the second test to make it receive onended and remove reftest-wait.
--- a/content/media/test/crashtests/925619-2.html
+++ b/content/media/test/crashtests/925619-2.html
@@ -1,14 +1,14 @@
<!DOCTYPE html>
<html class="reftest-wait">
<script>
+var context = new window.OfflineAudioContext(1, 2048, 48000);
// 1024 > 89478.5 * 48000 - (1 << 32)
-var context = new window.OfflineAudioContext(1, 1024, 48000);
-var buffer = context.createBuffer(1, 2048, context.sampleRate);
+var buffer = context.createBuffer(1, 1024, context.sampleRate);
|
||
Updated•11 years ago
|
Attachment #815715 -
Flags: review?(ehsan) → review+
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 815716 [details] [diff] [review]
simplify loop sanity checks
Review of attachment 815716 [details] [diff] [review]:
-----------------------------------------------------------------
::: content/media/webaudio/AudioBufferSourceNode.cpp
@@ +664,1 @@
> mLoopStart < mLoopEnd) {
Please add a MOZ_ASSERT with the removed condition to make the assumptions clearer when reading this code.
Attachment #815716 -
Flags: review?(ehsan) → review+
|
|
Assignee | |
Comment 7•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/506e26a05071
https://hg.mozilla.org/integration/mozilla-inbound/rev/05073dcfd397
Flags: in-testsuite+
|
||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/506e26a05071
https://hg.mozilla.org/mozilla-central/rev/05073dcfd397
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•